add rewrites in storybook preset #18364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-burel
requested review from
ijjk,
lfades,
Timer and
timneutkens
as code owners
This was referenced Oct 28, 2020
Closed
timneutkens
previously approved these changes
Oct 28, 2020
jamesgeorge007
pushed a commit
to jamesgeorge007/next.js
that referenced
this pull request
Nov 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The absence of a
rewritesoption in Storybook preset was failing it at runtime.It now works and solves storybookjs/storybook#11639 (it allows Storybook to support
tsconfigpathsout of the box like Next does).There is also an issue in line
if (!(rule.test instanceof RegExp)) return true, it is missing parenthesis. I'll try to provide another PR with a TS version and fix this issue too, because both issues are caught easily by TypeScript.