Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure only one doctype is rendered #31534

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Ensure only one doctype is rendered #31534

merged 2 commits into from
Nov 17, 2021

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Nov 17, 2021 •
edited by shuding
Loading

React-dom renders doctype automatically when <html> is detected. We should append DOCTYPE prefix only when necessary.
x-ref: facebook/react#21680

Bug

image

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Nov 17, 2021
@ijjk
Copy link
Member

ijjk commented Nov 17, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/duplicate-doctype Change
buildDuration 18.2s 18.1s -87ms
buildDurationCached 3.6s 3.6s ⚠️ +10ms
nodeModulesSize 336 MB 336 MB ⚠️ +187 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js fix/duplicate-doctype Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.998 2.991 -0.01
/ avg req/sec 833.86 835.97 +2.11
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.358 1.397 ⚠️ +0.04
/error-in-render avg req/sec 1841 1789.2 ⚠️ -51.8
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix/duplicate-doctype Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 28.3 kB 28.3 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 72.2 kB 72.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/duplicate-doctype Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary huozhi/next.js fix/duplicate-doctype Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 635 B 635 B ✓
image-HASH.js gzip 4.44 kB 4.44 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.87 kB 1.87 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 13.3 kB 13.3 kB ✓
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/duplicate-doctype Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/duplicate-doctype Change
index.html gzip 524 B 524 B ✓
link.html gzip 536 B 536 B ✓
withRouter.html gzip 517 B 517 B ✓
Overall change 1.58 kB 1.58 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/duplicate-doctype Change
buildDuration 19.6s 19.6s ⚠️ +58ms
buildDurationCached 3.6s 3.6s -17ms
nodeModulesSize 336 MB 336 MB ⚠️ +187 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js fix/duplicate-doctype Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.001 3 0
/ avg req/sec 833.03 833.2 +0.17
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.368 1.375 ⚠️ +0.01
/error-in-render avg req/sec 1826.94 1817.9 ⚠️ -9.04
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix/duplicate-doctype Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 28.6 kB 28.6 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 72.5 kB 72.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/duplicate-doctype Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary huozhi/next.js fix/duplicate-doctype Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 622 B 622 B ✓
image-HASH.js gzip 4.46 kB 4.46 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 1.91 kB 1.91 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 13.2 kB 13.2 kB ✓
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/duplicate-doctype Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/duplicate-doctype Change
index.html gzip 524 B 524 B ✓
link.html gzip 536 B 536 B ✓
withRouter.html gzip 517 B 517 B ✓
Overall change 1.58 kB 1.58 kB ✓
Commit: 1ec18fc

@kodiakhq kodiakhq bot merged commit 055e28e into vercel:canary Nov 17, 2021
@huozhi huozhi deleted the fix/duplicate-doctype branch November 17, 2021 16:29
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuding shuding shuding approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huozhi @ijjk @shuding