Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs][Fix] Broken Link to API Reference #31820

Merged
merged 2 commits into from
Nov 26, 2021
Merged

[Docs][Fix] Broken Link to API Reference #31820

merged 2 commits into from
Nov 26, 2021

Conversation

imabp
Copy link
Contributor

@imabp imabp commented Nov 26, 2021

Documentation / Examples

  • Make sure the linting passes by running yarn lint

Steps to Reproduce

  1. Go to https://nextjs.org/docs/advanced-features/debugging#debugging-with-vs-code

  2. Click on the link as shown in red underlined in below image.

image

  1. Ending up with the 404 Error screen

image

Fixing Steps

Replace the broken link with correct one.

@imabp imabp changed the title [Fix] Broken Link to API Reference [Docs][Fix] Broken Link to API Reference Nov 26, 2021
@imabp
Copy link
Contributor Author

imabp commented Nov 26, 2021

Hey @leerob you inspired me during your sessions at NextJS Conference.. This is my first contribution to NextJS, and I am trying to understand the codebase. Also, this makes an entry point for me. :)

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch 👍

@kodiakhq kodiakhq bot merged commit d72e429 into vercel:canary Nov 26, 2021
@imabp
Copy link
Contributor Author

imabp commented Nov 26, 2021

Hey @timneutkens , I want to be part of contributors list 🥺... If there is anything like that, please do add me :)

@leerob
Copy link
Member

leerob commented Nov 27, 2021

@imabp Thank you for your contribution! When we cut the next stable release, you will be shown in the contributors list 😁

@imabp
Copy link
Contributor Author

imabp commented Nov 27, 2021

Thank you @leerob . I was looking for more ways to contribute to the core part, or at least getting started. If there are any pointers or resources that can help me to contribute. Please do share here 😄. Also we are connected on twitter: https://twitter.com/imabptweets .. Really like what you do and showcase so many things like new NextCLI Rust Performance. So glad.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants