Update withData.js - support withRouter HOC #3286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for using withRouter as HOC with this example. Passing router context manually fixes this, based on, #2908 (comment)
timneutkens
reviewed
Nov 15, 2017
| @@ -54,7 +54,13 @@ export default ComposedComponent => { | |||
| <ComposedComponent url={url} {...composedInitialProps} /> | |||
| </ApolloProvider> | |||
| ) | |||
| await getDataFromTree(app) | |||
| await getDataFromTree(app, { | |||
| router: { | |||
There was a problem hiding this comment.
Does this break when you don't wrap withData in a withRouter?
There was a problem hiding this comment.
No, it does not break, I have various pages/components, some wrapped, some not wrapped.
timneutkens
approved these changes
Nov 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for using withRouter as HOC with this example.
Passing router context manually fixes this, based on, #2908 (comment)
This PR #3149, it it released yet? I am on 4.1.4 and I still require the above fix to make it work.