Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(examples/with-playwritght): use PORT env variable and fall back to 3000 #38107

Merged
merged 7 commits into from
Jul 8, 2022
Merged

fix(examples/with-playwritght): use PORT env variable and fall back to 3000 #38107

merged 7 commits into from
Jul 8, 2022

Conversation

thebergamo
Copy link
Contributor

Documentation / Examples

  • Related issues linked using fixes #37952
  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue was opened via the examples template. label Jun 28, 2022
@thebergamo thebergamo force-pushed the fix/playwright-example-port branch from aebd161 to c755905 Compare June 28, 2022 13:47
@thebergamo thebergamo force-pushed the fix/playwright-example-port branch from c755905 to 6576637 Compare June 29, 2022 08:20
@thebergamo thebergamo force-pushed the fix/playwright-example-port branch from 6576637 to 040dc79 Compare June 29, 2022 08:30
balazsorban44
balazsorban44 requested changes Jun 29, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, there was an unnecessary change, let's revert that so we can merge this!

@thebergamo
Copy link
Contributor Author

@balazsorban44 readme.md changes reverted.

@kodiakhq kodiakhq bot merged commit 34e296b into vercel:canary Jul 8, 2022
@thebergamo thebergamo deleted the fix/playwright-example-port branch July 8, 2022 21:22
@snyk-bot snyk-bot mentioned this pull request Jul 31, 2022
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thebergamo @balazsorban44 @ijjk