Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace JS blog-starter example with TS, deprecate blog-starter-typescript example #38395

Merged
merged 5 commits into from
Jul 8, 2022

Conversation

maxproske
Copy link
Contributor

@maxproske maxproske commented Jul 7, 2022

Replaced the main JavaScript blog-starter example with the TypeScript example, as was done with with-chakra-ui-typescript and with-chakra-ui.

It sounds like all examples will be TypeScript going forward, and it's less to maintain. #36333 (review)

The move:

  • Removed JS blog-starter example
  • Renamed TS blog-starter-typescript example to blog-starter
  • Added move notice at blog-starter-typescript/README.md

Improvements:

  • Upgraded all dependencies
  • Removed unused @types/jest dependency
  • Refactored split const/export page components to use export default function
  • Renamed types/ to interfaces/ to match with-typescript example

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue was opened via the examples template. label Jul 7, 2022
@ijjk ijjk merged commit 8783793 into vercel:canary Jul 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants