Send credentials with on-demand-entries-ping again #3968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
We can't send cookies with this request as a result of our multi-zones feature. #2498 is fine at that time since we didn't had that feature. Currently, we can't do that. As the original PR author mentioned, I suggest to use a workaround. |
|
So if my server has a middleware that checks if the user is authenticated (based on cookies) and branches out a different flow (e.g redirect to login page) if she isn't, then how do I filter out the on-demand-entries-ping calls during dev? Is that work around currently, the only way to do this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
client/on-demand-entries-client.jsparameter{ credentials: 'same-origin' }offetch()has been overwritten with{ credentials: 'omit' }when universal-webpack has been merged. This currently prevents on-demand-entries-ping requests from sending cookies which may be required for some development configurations, for example, for authentication. This pull request rolls it back tocredentials: 'same-origin'.See also: