-
Notifications
You must be signed in to change notification settings - Fork 27.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix next/image
404 when basePath
and trailingSlash
defined
#44312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basePath
and trailingSlash
definednext/image
404 when basePath
and trailingSlash
defined
Stats from current PRDefault Build (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size Overall increase
|
vercel/next.js canary | vercel/next.js styfle/next-322-images-fail | Change | |
---|---|---|---|
edge-ssr.js gzip | 110 kB | 110 kB | ✓ |
page.js gzip | 98.4 kB | 98.4 kB | |
Overall change | 209 kB | 209 kB |
Middleware size Overall increase ⚠️
vercel/next.js canary | vercel/next.js styfle/next-322-images-fail | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 584 B | 585 B | |
middleware-r..fest.js gzip | 145 B | 145 B | ✓ |
middleware.js gzip | 27 kB | 27 kB | ✓ |
edge-runtime..pack.js gzip | 1.83 kB | 1.83 kB | ✓ |
Overall change | 29.6 kB | 29.6 kB |
Diffs
Diff for page.js
@@ -8618,14 +8618,11 @@ Learn More: https://nextjs.org/docs/messages/node-module-in-edge-runtime`;
/***/
},
- /***/ 1036: /***/ (
+ /***/ 7997: /***/ (
__unused_webpack_module,
__unused_webpack_exports,
__webpack_require__
) => {
- Promise.resolve(/* import() eager */).then(
- __webpack_require__.bind(__webpack_require__, 1210)
- );
Promise.resolve(/* import() eager */).then(
__webpack_require__.bind(__webpack_require__, 2973)
);
@@ -8635,6 +8632,9 @@ Learn More: https://nextjs.org/docs/messages/node-module-in-edge-runtime`;
Promise.resolve(/* import() eager */).then(
__webpack_require__.bind(__webpack_require__, 9916)
);
+ Promise.resolve(/* import() eager */).then(
+ __webpack_require__.bind(__webpack_require__, 1210)
+ );
/***/
},
Diff for middleware-b..-manifest.js
@@ -9,7 +9,7 @@ self.__BUILD_MANIFEST = {
rootMainFiles: [
"static/chunks/webpack-c452a3e31b73f504.js",
"static/chunks/152-8467c9cd7467a603.js",
- "static/chunks/main-app-c9a0aaff35eafcb5.js"
+ "static/chunks/main-app-98f540113bfd845b.js"
],
pages: {
"/": [
Diff for main-app-HASH.js
@@ -1,14 +1,11 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
[744],
{
- /***/ 9915: /***/ function(
+ /***/ 2014: /***/ function(
__unused_webpack_module,
__unused_webpack_exports,
__webpack_require__
) {
- Promise.resolve(/* import() eager */).then(
- __webpack_require__.t.bind(__webpack_require__, 429, 23)
- );
Promise.resolve(/* import() eager */).then(
__webpack_require__.t.bind(__webpack_require__, 1161, 23)
);
@@ -18,6 +15,9 @@
Promise.resolve(/* import() eager */).then(
__webpack_require__.t.bind(__webpack_require__, 9379, 23)
);
+ Promise.resolve(/* import() eager */).then(
+ __webpack_require__.t.bind(__webpack_require__, 429, 23)
+ );
/***/
}
@@ -28,7 +28,7 @@
return __webpack_require__((__webpack_require__.s = moduleId));
};
/******/ __webpack_require__.O(0, [152], function() {
- return __webpack_exec__(7070), __webpack_exec__(9915);
+ return __webpack_exec__(7070), __webpack_exec__(2014);
});
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__;
ijjk
approved these changes
Dec 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trailingSlash
andbasePath
#36681