Move build directory outside of server folder #4565
Conversation
timneutkens
changed the title
# Conflicts: # server/utils.js
|
next-typescript has to be updated to reflect the changes in You can now use |
timneutkens
changed the title
| throw new Error('include option is not provided to hot-self-accept-loader. Please upgrade all next-plugins to the latest version.') | ||
| } | ||
|
|
||
| const dir = options.include.find((d) => resourcePath.indexOf(d) === 0) |
There was a problem hiding this comment.
do the indexOf outside of the predicate to a variable and use that in here
| import loaderUtils from 'loader-utils' | ||
|
|
||
| module.exports = function (content, sourceMap) { | ||
| type Options = { |
| include: [ | ||
| path.join(dir, 'pages') | ||
| ], | ||
| extensions: /\.(js|jsx)$/ |
There was a problem hiding this comment.
This is intended to not confuse people reading the code.
lib/constants.js
Outdated
| @@ -12,3 +13,9 @@ export const BLOCKED_PAGES = [ | |||
| '/_app', | |||
| '/_error' | |||
| ] | |||
| export const IS_BUNDLED_PAGE = /^bundles[/\\]pages.*\.js$/ | |||
| export const MATCH_ROUTE_NAME = /^bundles[/\\]pages[/\\](.*)\.js$/ | |||
There was a problem hiding this comment.
It's not obvious that these are Regexs. what do you think about BUNDLE_PAGE_REGEX and ROUTE_NAME_REGEX?
readme.md
Outdated
| - `buildId` - `String` the build id used as a unique identifier between builds | ||
| - `dev` - `Boolean` shows if the compilation is done in development mode | ||
| - `isServer` - `Boolean` shows if the resulting configuration will be used for server side (`true`), or client size compilation (`false`). | ||
| - `defaultLoaders` - `Object` Holds loaders Next.js uses internally, so that you can use them in custom configuration |
There was a problem hiding this comment.
I'm confused. Does defaultLoaders hold the loader objects themselves, or just the configuration objects for the loaders?
readme.md
Outdated
| module.exports = { | ||
| webpack: (config, {}) => { | ||
| config.module.rules.push({ | ||
| test: extension, |
There was a problem hiding this comment.
should we say test: /mdx?/ for the example?
server/utils.js
Outdated
| export function getChunkNameFromFilename (filename) { | ||
| export function getChunkNameFromFilename (filename, dev) { | ||
| if (dev) { | ||
| return filename.replace(/.[^.]*$/, '') |
There was a problem hiding this comment.
huh, is this because webpack handles naming different based on NODE_ENV?
There was a problem hiding this comment.
Yep, with chunk hash or without, but I didn't change this. It's from another PR.
The prepares for next-server. I also took this as an opportunity to get all build directory paths from a single location, as they were previously scattered across webpack/babel plugins and loaders.
The prepares for next-server.
I also took this as an opportunity to get all build directory paths from a single location, as they were previously scattered across webpack/babel plugins and loaders.