Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude transform-typeof-symbol #6812

Merged
merged 2 commits into from
Mar 30, 2019
Merged

Exclude transform-typeof-symbol #6812

merged 2 commits into from
Mar 30, 2019

Conversation

lfades
Copy link
Member

@lfades lfades commented Mar 27, 2019

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js exclude-typeof-transform Change
Build Duration 13.9s 13.2s -4.69%
Client _app Size 3.03 kB 3.03 kB ✓
Client _app gzip Size 1.29 kB 1.29 kB ✓
Client _error Size 8.43 kB 8.85 kB ⚠️ +4.93%
Client _error gzip Size 3.23 kB 3.31 kB ⚠️ +2.57%
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.31 kB 3.28 kB -0.73%
Client pages/link gzip Size 1.5 kB 1.49 kB -0.86%
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 21.7 kB 22.1 kB ⚠️ +1.92%
Client main gzip Size 7.16 kB 7.24 kB ⚠️ +1.19%
Client commons Size 183 kB 182 kB -0.33%
Client commons gzip Size 59.5 kB 59.4 kB -0.17%
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Base Rendered Size 1.3 kB 1.3 kB ✓
Build Dir Size 345 kB 345 kB ⚠️ +0.04%
Average Memory Usage 127 MB 126 MB -0.26%
Max Memory Usage 166 MB 162 MB -2.39%
Average CPU Usage 92.47% 93.66% ⚠️ +1.29%
Max CPU Usage 122.22% 122.22% ✓
node_modules Size 42.6 MB 42.6 MB 0%
Click to expand serverless stats
zeit/next.js canary lfades/next.js exclude-typeof-transform Change
Build Duration 17.3s 17.7s ⚠️ +2.21%
Client _app Size 3.03 kB 3.03 kB ✓
Client _app gzip Size 1.29 kB 1.29 kB ✓
Client _error Size 8.43 kB 8.85 kB ⚠️ +4.93%
Client _error gzip Size 3.23 kB 3.31 kB ⚠️ +2.57%
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.31 kB 3.28 kB -0.73%
Client pages/link gzip Size 1.5 kB 1.49 kB -0.86%
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 21.7 kB 22.1 kB ⚠️ +1.92%
Client main gzip Size 7.16 kB 7.24 kB ⚠️ +1.19%
Client commons Size 183 kB 182 kB -0.33%
Client commons gzip Size 59.5 kB 59.4 kB -0.17%
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Serverless pages/link Size 221 kB 220 kB -0.58%
Serverless pages/link gzip Size 58 kB 57.9 kB -0.03%
Serverless pages/index Size 216 kB 215 kB -0.56%
Serverless pages/index gzip Size 56.8 kB 56.7 kB -0.05%
Serverless pages/_error Size 218 kB 216 kB -0.56%
Serverless pages/_error gzip Size 56.7 kB 56.7 kB ⚠️ +0.01%
Serverless pages/routerDirect Size 217 kB 215 kB -0.56%
Serverless pages/routerDirect gzip Size 56.7 kB 56.7 kB -0.05%
Serverless pages/withRouter Size 217 kB 215 kB -0.56%
Serverless pages/withRouter gzip Size 56.8 kB 56.7 kB -0.11%
Build Dir Size 1.31 MB 1.31 MB -0.45%
Average Memory Usage 139 MB 141 MB ⚠️ +1.42%
Max Memory Usage 208 MB 187 MB -10.18%
Average CPU Usage 95.56% 95.23% -0.35%
Max CPU Usage 111.11% 122.22% ⚠️ +10%
node_modules Size 42.6 MB 42.6 MB 0%

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js exclude-typeof-transform Change
Build Duration 13.4s 13.4s -30ms
Client _app Size 3.03 kB 3.03 kB ✓
Client _app gzip Size 1.29 kB 1.29 kB ✓
Client _error Size 8.43 kB 8.85 kB ⚠️ +416 B
Client _error gzip Size 3.23 kB 3.31 kB ⚠️ +83 B
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.31 kB 3.28 kB -24 B
Client pages/link gzip Size 1.5 kB 1.49 kB -13 B
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 21.7 kB 22.1 kB ⚠️ +416 B
Client main gzip Size 7.16 kB 7.24 kB ⚠️ +85 B
Client commons Size 183 kB 182 kB -596 B
Client commons gzip Size 59.5 kB 59.4 kB -102 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Base Rendered Size 1.3 kB 1.3 kB ✓
Build Dir Size 346 kB 346 kB ⚠️ +127 B
Average Memory Usage 127 MB 128 MB ⚠️ +716 kB
Max Memory Usage 161 MB 166 MB ⚠️ +4.26 MB
Average CPU Usage 94.11% 93.9% -0.21%
Max CPU Usage 111.11% 111.11% ✓
node_modules Size 42.6 MB 42.6 MB -80 B
Click to expand serverless stats
zeit/next.js canary lfades/next.js exclude-typeof-transform Change
Build Duration 17.6s 17.3s -221ms
Client _app Size 3.03 kB 3.03 kB ✓
Client _app gzip Size 1.29 kB 1.29 kB ✓
Client _error Size 8.43 kB 8.85 kB ⚠️ +416 B
Client _error gzip Size 3.23 kB 3.31 kB ⚠️ +83 B
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.31 kB 3.28 kB -24 B
Client pages/link gzip Size 1.5 kB 1.49 kB -13 B
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 21.7 kB 22.1 kB ⚠️ +416 B
Client main gzip Size 7.16 kB 7.24 kB ⚠️ +85 B
Client commons Size 183 kB 182 kB -596 B
Client commons gzip Size 59.5 kB 59.4 kB -102 B
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Serverless pages/link Size 222 kB 220 kB -1.29 kB
Serverless pages/link gzip Size 58 kB 58 kB -5 B
Serverless pages/index Size 217 kB 215 kB -1.21 kB
Serverless pages/index gzip Size 56.8 kB 56.8 kB -17 B
Serverless pages/_error Size 218 kB 217 kB -1.21 kB
Serverless pages/_error gzip Size 56.8 kB 56.8 kB ⚠️ +14 B
Serverless pages/routerDirect Size 217 kB 216 kB -1.21 kB
Serverless pages/routerDirect gzip Size 56.8 kB 56.8 kB -24 B
Serverless pages/withRouter Size 217 kB 216 kB -1.21 kB
Serverless pages/withRouter gzip Size 56.9 kB 56.8 kB -54 B
Build Dir Size 1.31 MB 1.31 MB -5.93 kB
Average Memory Usage 139 MB 142 MB ⚠️ +2.91 MB
Max Memory Usage 207 MB 189 MB -18.3 MB
Average CPU Usage 95.25% 94.97% -0.28%
Max CPU Usage 111.11% 110% -1.11%
node_modules Size 42.6 MB 42.6 MB -80 B

@timneutkens timneutkens merged commit 6bb8327 into vercel:canary Mar 30, 2019
@timneutkens
Copy link
Member

Nice work @lfades 💯

@lfades lfades deleted the exclude-typeof-transform branch April 22, 2019 21:20
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@dav-is dav-is Awaiting requested review from dav-is

@ijjk ijjk Awaiting requested review from ijjk

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lfades @timneutkens