Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix application output #7264

Merged
merged 1 commit into from
May 6, 2019
Merged

Fix application output #7264

merged 1 commit into from
May 6, 2019

Conversation

Timer
Copy link
Member

@Timer Timer commented May 6, 2019

This fixes the finished message not appearing when in use with a custom server.

This looks like it was introduced by a bad git merge. 🤔

Fixes #7259

And #4016 (comment)

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary Timer/next.js fix-app-output Change
Build Duration 15.6s 14.6s -1s
node_modules Size 39.1 MB 39.1 MB ⚠️ +49 B
Total Bundle (main, webpack, commons) Size 209 kB 209 kB
Total Bundle (main, webpack, commons) gzip Size 68.4 kB 68.4 kB
Client _app Size 2.6 kB 2.6 kB
Client _app gzip Size 1.07 kB 1.07 kB
Client _error Size 8.19 kB 8.19 kB
Client _error gzip Size 3.12 kB 3.12 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.78 kB 4.78 kB
Client pages/link gzip Size 2.09 kB 2.09 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 23.3 kB 23.3 kB
Client main gzip Size 7.63 kB 7.63 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.4 kB 59.4 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 800 kB 800 kB
Click to expand serverless stats
zeit/next.js canary Timer/next.js fix-app-output Change
Build Duration 16.4s 16.1s -311ms
node_modules Size 39.1 MB 39.1 MB ⚠️ +49 B
Total Bundle (main, webpack, commons) Size 209 kB 209 kB
Total Bundle (main, webpack, commons) gzip Size 68.4 kB 68.4 kB
Client _app Size 2.6 kB 2.6 kB
Client _app gzip Size 1.07 kB 1.07 kB
Client _error Size 8.19 kB 8.19 kB
Client _error gzip Size 3.12 kB 3.12 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.78 kB 4.78 kB
Client pages/link gzip Size 2.09 kB 2.09 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 23.3 kB 23.3 kB
Client main gzip Size 7.63 kB 7.63 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.4 kB 59.4 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Serverless pages/link Size 342 kB 342 kB
Serverless pages/link gzip Size 88.7 kB 88.7 kB -2 B
Serverless pages/index Size 333 kB 333 kB
Serverless pages/index gzip Size 86.3 kB 86.3 kB ⚠️ +1 B
Serverless pages/_error Size 334 kB 334 kB
Serverless pages/_error gzip Size 86.1 kB 86.1 kB ⚠️ +2 B
Serverless pages/routerDirect Size 333 kB 333 kB
Serverless pages/routerDirect gzip Size 86.4 kB 86.4 kB ⚠️ +1 B
Serverless pages/withRouter Size 334 kB 334 kB
Serverless pages/withRouter gzip Size 86.5 kB 86.5 kB
Build Dir Size 2.37 MB 2.37 MB

@timneutkens timneutkens merged commit 948948f into vercel:canary May 6, 2019
@Timer Timer deleted the fix-app-output branch May 6, 2019 13:38
@jonnydungeons
Copy link

I am experiencing this issue on the latest version ^8.1.0. Has this fix been promoted to the master branch or is this on in canary? If it is only in canary then do you want us to update to the canary branch?

@Valnexus
Copy link

Valnexus commented Aug 8, 2019

I got the same issue, and I tried to do a next build, and I got the error that in css file a path to image was wrong, changed the path, did the build, and then run the server again, all good, strange but it worked.

@kozborn
Copy link

kozborn commented Sep 16, 2019

@Valnexus Same in my case, wrong path in css.

@0m15
Copy link

0m15 commented Oct 30, 2019

Me too stuck on building.No useful messages, nothing at all. Pffffffffff

@timneutkens
Copy link
Member

@kozborn @Valnexus @0m15 it's probably a good idea to read through this: https://twitter.com/timneutkens/status/1154351043049926656

It's not really useful to post "Same issue" on merged PRs, closed issues etc. Instead it is helpful if you provide a clear and concise reproduction of the issue you're having so that we can have a look and try to help you. Thanks 🙏

@vercel vercel locked as resolved and limited conversation to collaborators Oct 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App stuck at [wait] compiling ... using custom-express-server example
7 participants