-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DevOverlay] Enable new UI when PPR testing is enabled #74935
base: 01-17-_devoverlay_open_error_overlay_when_devtools_indicator_clicked
Are you sure you want to change the base?
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Failing test suitesCommit: 4c613a2
Expand output● app dir - dynamic error trace › should show the error trace
Read more about building and testing Next.js in contributing.md.
Expand output● app-dir - owner-stack-react-missing-key-prop › should catch invalid element from on rsc component
Read more about building and testing Next.js in contributing.md.
Expand output● app-dir - capture-console-error › should capture browser console error and format the error message
● app-dir - capture-console-error › should capture browser console error in render and dedupe if necessary
● app-dir - capture-console-error › should capture browser console error in render and dedupe when multi same errors logged
● app-dir - capture-console-error › should capture server replay string error from console error
● app-dir - capture-console-error › should capture server replay error instance from console error
● app-dir - capture-console-error › should be able to capture rsc logged error
Read more about building and testing Next.js in contributing.md.
Expand output● app-dir - react-missing-key-prop › should catch invalid element from on rsc component
● app-dir - react-missing-key-prop › should catch invalid element from on ssr client component
Read more about building and testing Next.js in contributing.md.
Expand output● serialize-circular-error › should serialize the object from server component in console correctly
Read more about building and testing Next.js in contributing.md.
Expand output● app-dir - owner-stack › should log stitched error for browser uncaught errors
● app-dir - owner-stack › should log stitched error for browser caught errors
● app-dir - owner-stack › should log stitched error for SSR errors
Read more about building and testing Next.js in contributing.md.
Expand output● prerender indicator › should have prerender-indicator by default for static page
Read more about building and testing Next.js in contributing.md.
Expand output● app dir - global error - with style import › should render global error with correct styles
Read more about building and testing Next.js in contributing.md.
Expand output● server-navigation-error › pages router › should error on navigation API redirect
● server-navigation-error › pages router › should error on navigation API notFound
● server-navigation-error › middleware › should error on navigation API redirect
● server-navigation-error › middleware › should error on navigation API not-found
Read more about building and testing Next.js in contributing.md.
Expand output● non-root-project-monorepo › source-maps › should work on RSC
● non-root-project-monorepo › source-maps › should work on SSR
● non-root-project-monorepo › source-maps › should work on client-side
Read more about building and testing Next.js in contributing.md.
Expand output● ReactRefreshLogBox turbo › should show anonymous frames from stack trace
● ReactRefreshLogBox turbo › should collapse nodejs internal stack frames from stack trace
Read more about building and testing Next.js in contributing.md. |
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | vercel/next.js 01-16-_devoverlay_enable_new_ui_when_ppr_testing_is_enabled | Change | |
---|---|---|---|
buildDuration | 18.6s | 15.5s | N/A |
buildDurationCached | 14.7s | 12.1s | N/A |
nodeModulesSize | 418 MB | 418 MB | |
nextStartRea..uration (ms) | 396ms | 397ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js 01-16-_devoverlay_enable_new_ui_when_ppr_testing_is_enabled | Change | |
---|---|---|---|
5306-HASH.js gzip | 54 kB | 54 kB | N/A |
8276.HASH.js gzip | 169 B | 168 B | N/A |
8377-HASH.js gzip | 5.44 kB | 5.44 kB | N/A |
bccd1874-HASH.js gzip | 52.9 kB | 52.9 kB | ✓ |
framework-HASH.js gzip | 57.5 kB | 57.5 kB | N/A |
main-app-HASH.js gzip | 240 B | 242 B | N/A |
main-HASH.js gzip | 34.3 kB | 34.3 kB | N/A |
webpack-HASH.js gzip | 1.71 kB | 1.71 kB | N/A |
Overall change | 52.9 kB | 52.9 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js 01-16-_devoverlay_enable_new_ui_when_ppr_testing_is_enabled | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 39.4 kB | 39.4 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js 01-16-_devoverlay_enable_new_ui_when_ppr_testing_is_enabled | Change | |
---|---|---|---|
_app-HASH.js gzip | 193 B | 193 B | ✓ |
_error-HASH.js gzip | 193 B | 193 B | ✓ |
amp-HASH.js gzip | 512 B | 510 B | N/A |
css-HASH.js gzip | 343 B | 342 B | N/A |
dynamic-HASH.js gzip | 1.84 kB | 1.84 kB | ✓ |
edge-ssr-HASH.js gzip | 265 B | 265 B | ✓ |
head-HASH.js gzip | 363 B | 362 B | N/A |
hooks-HASH.js gzip | 393 B | 392 B | N/A |
image-HASH.js gzip | 4.57 kB | 4.57 kB | N/A |
index-HASH.js gzip | 268 B | 268 B | ✓ |
link-HASH.js gzip | 2.35 kB | 2.34 kB | N/A |
routerDirect..HASH.js gzip | 328 B | 328 B | ✓ |
script-HASH.js gzip | 397 B | 397 B | ✓ |
withRouter-HASH.js gzip | 323 B | 326 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 3.59 kB | 3.59 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js 01-16-_devoverlay_enable_new_ui_when_ppr_testing_is_enabled | Change | |
---|---|---|---|
_buildManifest.js gzip | 749 B | 747 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js 01-16-_devoverlay_enable_new_ui_when_ppr_testing_is_enabled | Change | |
---|---|---|---|
index.html gzip | 522 B | 524 B | N/A |
link.html gzip | 538 B | 537 B | N/A |
withRouter.html gzip | 519 B | 520 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js 01-16-_devoverlay_enable_new_ui_when_ppr_testing_is_enabled | Change | |
---|---|---|---|
edge-ssr.js gzip | 129 kB | 129 kB | N/A |
page.js gzip | 208 kB | 208 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js 01-16-_devoverlay_enable_new_ui_when_ppr_testing_is_enabled | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 668 B | 665 B | N/A |
middleware-r..fest.js gzip | 155 B | 156 B | N/A |
middleware.js gzip | 31.3 kB | 31.3 kB | N/A |
edge-runtime..pack.js gzip | 844 B | 844 B | ✓ |
Overall change | 844 B | 844 B | ✓ |
Next Runtimes
vercel/next.js canary | vercel/next.js 01-16-_devoverlay_enable_new_ui_when_ppr_testing_is_enabled | Change | |
---|---|---|---|
274-experime...dev.js gzip | 322 B | 322 B | ✓ |
274.runtime.dev.js gzip | 314 B | 314 B | ✓ |
app-page-exp...dev.js gzip | 374 kB | 373 kB | N/A |
app-page-exp..prod.js gzip | 130 kB | 130 kB | ✓ |
app-page-tur..prod.js gzip | 143 kB | 143 kB | ✓ |
app-page-tur..prod.js gzip | 139 kB | 139 kB | ✓ |
app-page.run...dev.js gzip | 362 kB | 361 kB | N/A |
app-page.run..prod.js gzip | 126 kB | 126 kB | ✓ |
app-route-ex...dev.js gzip | 37.6 kB | 37.6 kB | ✓ |
app-route-ex..prod.js gzip | 25.6 kB | 25.6 kB | ✓ |
app-route-tu..prod.js gzip | 25.6 kB | 25.6 kB | ✓ |
app-route-tu..prod.js gzip | 25.4 kB | 25.4 kB | ✓ |
app-route.ru...dev.js gzip | 39.2 kB | 39.2 kB | ✓ |
app-route.ru..prod.js gzip | 25.4 kB | 25.4 kB | ✓ |
pages-api-tu..prod.js gzip | 9.69 kB | 9.69 kB | ✓ |
pages-api.ru...dev.js gzip | 11.6 kB | 11.6 kB | ✓ |
pages-api.ru..prod.js gzip | 9.68 kB | 9.68 kB | ✓ |
pages-turbo...prod.js gzip | 21.8 kB | 21.8 kB | ✓ |
pages.runtim...dev.js gzip | 27.6 kB | 27.6 kB | ✓ |
pages.runtim..prod.js gzip | 21.8 kB | 21.8 kB | ✓ |
server.runti..prod.js gzip | 916 kB | 916 kB | ✓ |
Overall change | 1.74 MB | 1.74 MB | ✓ |
build cache Overall increase ⚠️
vercel/next.js canary | vercel/next.js 01-16-_devoverlay_enable_new_ui_when_ppr_testing_is_enabled | Change | |
---|---|---|---|
0.pack gzip | 2.09 MB | 2.09 MB | N/A |
index.pack gzip | 74.7 kB | 75.3 kB | |
Overall change | 74.7 kB | 75.3 kB |
Diff details
Diff for main-HASH.js
Diff too large to display
Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js
failed to diff
279cbd2
to
003a61d
Compare
7d9c834
to
f477735
Compare
003a61d
to
4a0c516
Compare
f477735
to
ee2754d
Compare
ee2754d
to
7c8e142
Compare
c671e8a
to
ddf157e
Compare
7c8e142
to
7b6ba6e
Compare
970daea
to
8bea48c
Compare
7b6ba6e
to
e6d41c4
Compare
8bea48c
to
ac0f76f
Compare
6649e86
to
f2f1850
Compare
0d43d19
to
05b4b00
Compare
58e767c
to
99fbf39
Compare
5820d4d
to
39be163
Compare
99fbf39
to
ee226a6
Compare
Closes NDX-674