Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Turbopack] Memory improvements #75210

Merged
merged 7 commits into from
Jan 23, 2025
Merged

[Turbopack] Memory improvements #75210

merged 7 commits into from
Jan 23, 2025

Conversation

sokra
Copy link
Member

@sokra sokra commented Jan 22, 2025

What?

  • add tracing for resolve plugins
  • convert BeforeResolvePluginCondition::matches to a turbo-tasks function
  • remove storage on update too
  • avoid overreserving storages
  • remove PersistentUpperCount

Closes PACK-3794

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Jan 22, 2025
Copy link
Member Author

sokra commented Jan 22, 2025

@sokra sokra changed the title add tracing for resolve plugins [Turbopack] Memory improvements Jan 22, 2025
@sokra sokra marked this pull request as ready for review January 22, 2025 23:47
@ijjk
Copy link
Member

ijjk commented Jan 22, 2025

Tests Passed

@ijjk
Copy link
Member

ijjk commented Jan 23, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sokra/memory-improvements Change
buildDuration 17s 15.6s N/A
buildDurationCached 14.8s 12.4s N/A
nodeModulesSize 419 MB 419 MB
nextStartRea..uration (ms) 397ms 399ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/memory-improvements Change
5306-HASH.js gzip 54.1 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 34.6 kB 34.6 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/memory-improvements Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js sokra/memory-improvements Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/memory-improvements Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/memory-improvements Change
index.html gzip 523 B 522 B N/A
link.html gzip 538 B 537 B N/A
withRouter.html gzip 520 B 520 B
Overall change 520 B 520 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/memory-improvements Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 209 kB 209 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sokra/memory-improvements Change
middleware-b..fest.js gzip 671 B 666 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js sokra/memory-improvements Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 376 kB 376 kB
app-page-exp..prod.js gzip 131 kB 131 kB
app-page-tur..prod.js gzip 144 kB 144 kB
app-page-tur..prod.js gzip 140 kB 140 kB
app-page.run...dev.js gzip 364 kB 364 kB
app-page.run..prod.js gzip 127 kB 127 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 27.7 kB 27.7 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.48 MB 2.48 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sokra/memory-improvements Change
0.pack gzip 2.1 MB 2.11 MB ⚠️ +4.35 kB
index.pack gzip 75.8 kB 74.8 kB N/A
Overall change 2.1 MB 2.11 MB ⚠️ +4.35 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 11f1723

@sokra sokra changed the base branch from sokra/new-backend to graphite-base/75210 January 23, 2025 00:25
@sokra sokra force-pushed the sokra/memory-improvements branch from ab16abc to db38fbb Compare January 23, 2025 00:25
@sokra sokra force-pushed the graphite-base/75210 branch from 0c7cbc2 to c33eb2b Compare January 23, 2025 00:25
@sokra sokra changed the base branch from graphite-base/75210 to canary January 23, 2025 00:26
@sokra sokra force-pushed the sokra/memory-improvements branch from db38fbb to 11f1723 Compare January 23, 2025 00:26
@sokra sokra requested a review from mischnic January 23, 2025 07:12
@sokra sokra merged commit 9083d93 into canary Jan 23, 2025
131 checks passed
@sokra sokra deleted the sokra/memory-improvements branch January 23, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants