Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update styled-jsx #8583

Merged
merged 2 commits into from
Aug 31, 2019
Merged

Update styled-jsx #8583

merged 2 commits into from
Aug 31, 2019

Conversation

giuseppeg
Copy link
Contributor

Fixes an escaping issue in template literals that @lfades found

@giuseppeg
Update styled-jsx
bf50e79 
Fixes an escaping issue in template literals that @lfades found
@ijjk
Copy link
Member

ijjk commented Aug 31, 2019

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary giuseppeg/next.js patch-9 Change
buildDuration 24.3s 24.2s -165ms
nodeModulesSize 42 MB 42.4 MB ⚠️ +422 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary giuseppeg/next.js patch-9 Change
main-HASH.js 18.3 kB 18.3 kB ✓
main-HASH.js gzip 6.66 kB 6.66 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary giuseppeg/next.js patch-9 Change
main-HASH.module.js 16.6 kB 16.6 kB ✓
main-HASH.module.js gzip 6.39 kB 6.39 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary giuseppeg/next.js patch-9 Change
_app.js 1.83 kB 1.83 kB ✓
_app.js gzip 884 B 884 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary giuseppeg/next.js patch-9 Change
_app.module.js 1.73 kB 1.73 kB ✓
_app.module.js gzip 840 B 840 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary giuseppeg/next.js patch-9 Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Rendered Page Sizes
zeit/next.js canary giuseppeg/next.js patch-9 Change
index.html 3.7 kB 3.7 kB ✓
index.html gzip 955 B 953 B -2 B
link.html 3.75 kB 3.75 kB ✓
link.html gzip 964 B 961 B -3 B
withRouter.html 3.75 kB 3.75 kB ✓
withRouter.html gzip 951 B 948 B -3 B
Overall change ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary giuseppeg/next.js patch-9 Change
buildDuration 24.9s 24.9s -32ms
nodeModulesSize 42 MB 42.4 MB ⚠️ +422 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary giuseppeg/next.js patch-9 Change
main-HASH.js 18.3 kB 18.3 kB ✓
main-HASH.js gzip 6.66 kB 6.66 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary giuseppeg/next.js patch-9 Change
main-HASH.module.js 16.6 kB 16.6 kB ✓
main-HASH.module.js gzip 6.39 kB 6.39 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary giuseppeg/next.js patch-9 Change
_app.js 1.83 kB 1.83 kB ✓
_app.js gzip 884 B 884 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary giuseppeg/next.js patch-9 Change
_app.module.js 1.73 kB 1.73 kB ✓
_app.module.js gzip 840 B 840 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary giuseppeg/next.js patch-9 Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary giuseppeg/next.js patch-9 Change
_error.js 247 kB 247 kB -5 B
_error.js gzip 66.3 kB 66.4 kB ⚠️ +102 B
hooks.html 3.81 kB 3.81 kB -1 B
hooks.html gzip 980 B 981 B ⚠️ +1 B
index.js 248 kB 248 kB -5 B
index.js gzip 66.6 kB 66.6 kB -26 B
link.js 256 kB 256 kB -5 B
link.js gzip 68.8 kB 68.9 kB ⚠️ +37 B
routerDirect.js 249 kB 249 kB -5 B
routerDirect.js gzip 66.8 kB 66.7 kB -170 B
withRouter.js 249 kB 249 kB -5 B
withRouter.js gzip 66.8 kB 66.6 kB -117 B
Overall change -26 B

@ijjk
Copy link
Member

ijjk commented Aug 31, 2019

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary giuseppeg/next.js patch-9 Change
buildDuration 21.1s 21.1s -50ms
nodeModulesSize 42 MB 42 MB ⚠️ +117 B
Client Bundles (main, webpack, commons)
zeit/next.js canary giuseppeg/next.js patch-9 Change
main-HASH.js 18.3 kB 18.3 kB ✓
main-HASH.js gzip 6.66 kB 6.66 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary giuseppeg/next.js patch-9 Change
main-HASH.module.js 16.6 kB 16.6 kB ✓
main-HASH.module.js gzip 6.39 kB 6.39 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary giuseppeg/next.js patch-9 Change
_app.js 1.83 kB 1.83 kB ✓
_app.js gzip 884 B 884 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary giuseppeg/next.js patch-9 Change
_app.module.js 1.73 kB 1.73 kB ✓
_app.module.js gzip 840 B 840 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary giuseppeg/next.js patch-9 Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Rendered Page Sizes
zeit/next.js canary giuseppeg/next.js patch-9 Change
index.html 3.7 kB 3.7 kB ✓
index.html gzip 957 B 959 B ⚠️ +2 B
link.html 3.74 kB 3.74 kB ✓
link.html gzip 966 B 968 B ⚠️ +2 B
withRouter.html 3.75 kB 3.75 kB ✓
withRouter.html gzip 952 B 953 B ⚠️ +1 B
Overall change ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary giuseppeg/next.js patch-9 Change
buildDuration 22.2s 22s -164ms
nodeModulesSize 42 MB 42 MB ⚠️ +117 B
Client Bundles (main, webpack, commons)
zeit/next.js canary giuseppeg/next.js patch-9 Change
main-HASH.js 18.3 kB 18.3 kB ✓
main-HASH.js gzip 6.66 kB 6.66 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary giuseppeg/next.js patch-9 Change
main-HASH.module.js 16.6 kB 16.6 kB ✓
main-HASH.module.js gzip 6.39 kB 6.39 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary giuseppeg/next.js patch-9 Change
_app.js 1.83 kB 1.83 kB ✓
_app.js gzip 884 B 884 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary giuseppeg/next.js patch-9 Change
_app.module.js 1.73 kB 1.73 kB ✓
_app.module.js gzip 840 B 840 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary giuseppeg/next.js patch-9 Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Serverless bundles
zeit/next.js canary giuseppeg/next.js patch-9 Change
_error.js 247 kB 247 kB ✓
_error.js gzip 66.3 kB 66.3 kB ⚠️ +10 B
hooks.html 3.81 kB 3.81 kB ✓
hooks.html gzip 981 B 980 B -1 B
index.js 248 kB 248 kB ✓
index.js gzip 66.7 kB 66.8 kB ⚠️ +42 B
link.js 256 kB 256 kB ✓
link.js gzip 68.8 kB 68.9 kB ⚠️ +82 B
routerDirect.js 249 kB 249 kB ✓
routerDirect.js gzip 66.7 kB 66.7 kB ⚠️ +30 B
withRouter.js 249 kB 249 kB ✓
withRouter.js gzip 66.9 kB 66.7 kB -193 B
Overall change ✓

@ijjk ijjk merged commit ad0cca9 into vercel:canary Aug 31, 2019
@huv1k huv1k added this to the 9.0.6 milestone Sep 2, 2019
This was referenced Sep 16, 2021
Open
Open
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.0.6
Development

Successfully merging this pull request may close these issues.
3 participants
@giuseppeg @ijjk @huv1k