Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow config.public to be an absolute path #50

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Allow config.public to be an absolute path #50

merged 1 commit into from
Aug 21, 2018

Conversation

balupton
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 20, 2018

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #50   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         305    305           
=====================================
  Hits          305    305
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d934514...0869a56. Read the comment docs.

ray0324
ray0324 reviewed Aug 21, 2018
View reviewed changes
Copy link

@ray0324 ray0324 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is good ,I've used in my project the public configed as 'E:/Webroot/' and works well

ray0324
ray0324 approved these changes Aug 21, 2018
View reviewed changes
Copy link

@ray0324 ray0324 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is good ,I've used in my project the public configed as 'E:/Webroot/' and works well

@leo leo self-requested a review August 21, 2018 10:24
@leo
Copy link
Contributor

leo commented Aug 21, 2018

Thank you!

@leo leo merged commit 4f3e80f into vercel:master Aug 21, 2018
@leo leo mentioned this pull request Aug 21, 2018
Closed
@balupton balupton deleted the patch-1 branch August 13, 2020 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ray0324 ray0324 ray0324 approved these changes

@leo leo leo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balupton @leo @ray0324