-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refc: rewrite the project in typescript #706
Conversation
I've tried to stick as close to the style guide as possible, but please let me know if there's something I missed and should change! |
This is awesome! Going to dig into this and give it a thorough review. |
@gamemaker1 I have ported my work in #580 to code based on your current PR. How do you want me to push this? Directly to this PR or separate one? |
@schemburkar That was really fast 🎉 Thanks for the amazing work on the PR! I think it makes sense to keep the certificate PR separate and merge it in after this PR. I want to make a couple of other PRs too, like the logging one and changes from useful forks like https://github.com/warren-bank/node-serve, but I'll wait until this one is merged and then make those separately. It'll make it easier for the Vercel team to review changes :] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, a huge effort - thanks!
Let me know if you want help or want to pair on any of the comments, more than happy to help with any of it.
Removed all the |
Any other changes I should make? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of my comments have been addressed. To reiterate, we will be releasing this as a major version and can write a nice summary in the release notes to let folks know what changed.
Let's get two other +1s and we can ship it.
That's great! Once this PR is merged, I would love to help out with adding the tests and some features from forks like https://github.com/warren-bank/node-serve; looking forward to collaborating with all of you on it :] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. I'm not an expert on this package, but the changes you've made look logical and you've done a great job of typing and adhering to our style guide - thank you!
Thank you @gamemaker1 🙏 Would love to send you some Vercel swag (shoot me an email |
|
Confirmed things are working as expected, publishing stable – will keep an eye on issues 😄 |
So far I've only seen one small bug: #711 |
Wow, thank you! I will send you an email today :] |
Related Issues
Description
This PR:
lint
andtest
steps to the GitHub workflowChecklist
pnpm test
) pass.pnpm lint
) does not throw an errors.methods/classes/constants/types have been annotated with TSDoc comments.