-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
6 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5795f33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because now all the substates (data, error, isValidating) are returned from getters which return refs (https://github.com/zeit/swr/pull/186/files#diff-ab20307c185620c9b54994fa4dcee1b7R608), the comparison result here (5795f33#diff-c9d2eb3ea821da85bd697b22fe31edf4R147) will always be
true
(both return the same ref).This commit breaks the state object into a new one (which doesn't have the getters).