Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update to [email protected] and use node 18 everywhere in CI #5235

Merged
merged 10 commits into from
Aug 11, 2023
Merged

chore: update to [email protected] and use node 18 everywhere in CI #5235

merged 10 commits into from
Aug 11, 2023

Conversation

ForsakenHarmony
Copy link
Contributor

@ForsakenHarmony ForsakenHarmony commented Jun 7, 2023 •
edited
Loading

@vercel
Copy link

vercel bot commented Jun 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-cra-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 3:03pm
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2023 3:03pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2023 3:03pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2023 3:03pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2023 3:03pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2023 3:03pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2023 3:03pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2023 3:03pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2023 3:03pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2023 3:03pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2023 3:03pm

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023 •
edited
Loading

✅ This change can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@socket-security
Copy link

socket-security bot commented Jun 7, 2023 •
edited
Loading

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
next 13.4.12 eval, network, filesystem, shell, environment +12 61.9 MB vercel-release-bot
ts-node 10.9.1 filesystem, environment +0 747 kB cspotcode
eslint-config-prettier 8.5.0 None +1 2.87 MB lydell
ts-jest 27.1.5 filesystem, environment +40 23.2 MB kul
tsup 5.12.9 eval, filesystem, environment +6 22.8 MB egoist
tsup 6.7.0 eval, filesystem, environment +4 3.5 MB egoist
autoprefixer 10.4.14 filesystem, shell, environment +2 274 kB ai
tailwindcss 3.1.8 filesystem, environment +0 4.43 MB adamwathan
semver 7.3.8...7.5.0 None +0/-0 91.4 kB npm-cli-ops
eslint 8.23.0...8.29.0 environment +0/-0 2.85 MB eslintbot

🚮 Removed packages: [email protected], [email protected], [email protected]

@mehulkar
Copy link
Contributor

mehulkar commented Jun 8, 2023

FYI, some related work here #5030, but there were a couple issues with it that I didn't have time to resolve.

@ForsakenHarmony
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@socket-security
Copy link

socket-security bot commented Aug 4, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: [email protected]

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples area: site pkg: create-turbo Issues related to npx create-turbo pkg: turbo-codemod pkg: turbo-eslint eslint-config-turbo and eslint-plugin-turbo pkg: turbo-gen pkg: turbo-ignore packages/turbo-ignore pkg: turbo-workspaces labels Aug 4, 2023
@ForsakenHarmony ForsakenHarmony changed the title update to pnpm 8 and allow newer node versions chore: update to [email protected] and use node 18 in CI Aug 4, 2023
@ForsakenHarmony
Copy link
Contributor Author

@SocketSecurity ignore next@*

@vercel vercel deleted a comment from github-actions bot Aug 4, 2023
@vercel vercel deleted a comment from github-actions bot Aug 4, 2023
@vercel vercel deleted a comment from github-actions bot Aug 4, 2023
@vercel vercel deleted a comment from github-actions bot Aug 8, 2023
@vercel vercel deleted a comment from github-actions bot Aug 8, 2023
@ForsakenHarmony ForsakenHarmony changed the title chore: update to [email protected] and use node 18 in CI chore: update to [email protected] and use node 18 everywhere in CI Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Linux Benchmark for a2599a8

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 5425.22µs ± 24.02µs 5470.29µs ± 14.78µs +0.83%
bench_hmr_to_eval/Turbopack CSR/1000 modules 5125.09µs ± 22.32µs 5101.18µs ± 16.18µs -0.47%
bench_startup/Turbopack CSR/1000 modules 982.43ms ± 1.12ms 981.15ms ± 1.87ms -0.13%

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

MacOS Benchmark for a2599a8

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 4605.84ms ± 183.75ms 3662.50ms ± 118.93ms -20.48% -7.97%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 27.70ms ± 0.15ms 27.94ms ± 0.25ms +0.86%
bench_hmr_to_eval/Turbopack CSR/1000 modules 27.34ms ± 0.52ms 26.95ms ± 0.11ms -1.45%
bench_startup/Turbopack CSR/1000 modules 4605.84ms ± 183.75ms 3662.50ms ± 118.93ms -20.48% -7.97%

@ForsakenHarmony ForsakenHarmony merged commit 22d5875 into main Aug 11, 2023
@ForsakenHarmony ForsakenHarmony deleted the hrmny/update-pnpm branch August 11, 2023 14:41
X-oss-byte pushed a commit to X-oss-byte/turbo that referenced this pull request Aug 29, 2023
@ForsakenHarmony @X-oss-byte
chore: update to [email protected] and use node 18 everywhere in CI (verc…
dcaceea 
…el#5235)
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@ForsakenHarmony
chore: update to [email protected] and use node 18 everywhere in CI (verc…
efb925e 
…el/turborepo#5235)
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@ForsakenHarmony
chore: update to [email protected] and use node 18 everywhere in CI (verc…
7a83382 
…el/turborepo#5235)
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@ForsakenHarmony
chore: update to [email protected] and use node 18 everywhere in CI (verc…
8433b1f 
…el/turborepo#5235)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

@alexkirsz alexkirsz alexkirsz approved these changes

@kdy1 kdy1 kdy1 approved these changes

@anthonyshew anthonyshew Awaiting requested review from anthonyshew anthonyshew is a code owner

@nathanhammond nathanhammond Awaiting requested review from nathanhammond nathanhammond is a code owner automatically assigned from vercel/turbo-oss

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: ci area: examples Improvements or additions to examples area: site pkg: create-turbo Issues related to npx create-turbo pkg: turbo-codemod pkg: turbo-eslint eslint-config-turbo and eslint-plugin-turbo pkg: turbo-gen pkg: turbo-ignore packages/turbo-ignore pkg: turbo-workspaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ForsakenHarmony @mehulkar @jridgewell @alexkirsz @kdy1