Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable default features for turbopack-ecmascript-plugins #5363

Merged
merged 6 commits into from
Jun 22, 2023
Merged

Conversation

sokra
Copy link
Member

@sokra sokra commented Jun 22, 2023

Description

it breaks no-plugin in next.js

@sokra sokra requested a review from a team as a code owner June 22, 2023 17:25
@vercel
Copy link

vercel bot commented Jun 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 8:13pm
examples-svelte-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 8:13pm
9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2023 8:13pm
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2023 8:13pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2023 8:13pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2023 8:13pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2023 8:13pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2023 8:13pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2023 8:13pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2023 8:13pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2023 8:13pm

@github-actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)
  • Formatting

See workflow summary for details

@github-actions
Copy link
Contributor

Linux Benchmark for 6eb4355

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 11.04ms ± 0.06ms 10.90ms ± 0.04ms -1.32%
bench_hmr_to_eval/Turbopack CSR/1000 modules 10.13ms ± 0.07ms 10.54ms ± 0.48ms +3.97%
bench_startup/Turbopack CSR/1000 modules 1146.34ms ± 2.86ms 1162.59ms ± 11.82ms +1.42%

@sokra sokra requested a review from a team as a code owner June 22, 2023 18:10
@sokra sokra requested review from chris-olszewski and arlyon June 22, 2023 18:10
@github-actions
Copy link
Contributor

Linux Benchmark for d6c7e46

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 10.72ms ± 0.04ms 10.64ms ± 0.04ms -0.69%
bench_hmr_to_eval/Turbopack CSR/1000 modules 10.02ms ± 0.09ms 9983.47µs ± 70.69µs -0.33%
bench_startup/Turbopack CSR/1000 modules 1135.12ms ± 2.93ms 1139.36ms ± 6.50ms +0.37%

@sokra sokra merged commit 08aba99 into main Jun 22, 2023
@sokra sokra deleted the sokra/app-edge-3 branch June 22, 2023 21:09
@github-actions
Copy link
Contributor

Windows Benchmark for d6c7e46

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 3482.64ms ± 8.97ms 3541.43ms ± 16.75ms +1.69% +0.21%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 15.60ms ± 0.01ms 15.65ms ± 0.02ms +0.30%
bench_hmr_to_eval/Turbopack CSR/1000 modules 15.56ms ± 0.02ms 18.10ms ± 2.05ms +16.28%
bench_startup/Turbopack CSR/1000 modules 3482.64ms ± 8.97ms 3541.43ms ± 16.75ms +1.69% +0.21%

sokra added a commit to vercel/next.js that referenced this pull request Jun 23, 2023
relanding #50830 and #51631 

### Turbopack Changes

* vercel/turborepo#5254 <!-- OJ Kwon - ci(workflow):
upload daily next.js test trace -->
* vercel/turborepo#5363 <!-- Tobias Koppers -
disable default features for turbopack-ecmascript-plugins -->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants