Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(errors): improve error message for recursive calls #9650

Merged
merged 9 commits into from
Jan 2, 2025
Merged

Conversation

anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented Dec 24, 2024

Closes #9224

Description

This is a state that you can get into two ways:

  • Genuinely configuring their way into a loop with misconfigured scripts and tasks
  • Accidentally misconfiguring their package manager Workspace
    • In some misconfigurations, the Workspace will look like a single-package Workspace, but the previous iteration of our error message didn't give any hints about this.

Either way, we should be providing an informative error message, so this PR provides a message that caters to both situations. We'll need a more verbose explanation, so an error link has been added here, as well.

Testing Instructions

Delete pnpm-workspace.yaml from create-turbo, remove turbo from devDependencies, re-run package manager installation, and try to run turbo build. You should be greeted by this new and improved error message.

Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 8:25pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 8:25pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 8:25pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 8:25pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 8:25pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 8:25pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 8:25pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 8:25pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 8:25pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading error when pnpm-workspace.yaml is missing
2 participants