-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(examples): mark core supported examples #9707
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbo-orchestrator
bot
added
the
area: examples
Improvements or additions to examples
label
Jan 15, 2025
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
turbo-orchestrator
bot
added
the
pkg: create-turbo
Issues related to npx create-turbo
label
Jan 15, 2025
chris-olszewski
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small follow up regarding create-turbo
logging
@tknickman Thought it was going to bloat the PR for review, but I'm game! Done! |
tknickman
reviewed
Jan 16, 2025
anthonyshew
commented
Jan 16, 2025
anthonyshew
commented
Jan 16, 2025
anthonyshew
commented
Jan 16, 2025
anthonyshew
commented
Jan 16, 2025
anthonyshew
commented
Jan 16, 2025
anthonyshew
commented
Jan 16, 2025
tknickman
approved these changes
Jan 17, 2025
This was referenced Jan 18, 2025
anthonyshew
added a commit
that referenced
this pull request
Jan 18, 2025
### Description Following up on #9707 with a note in CONTRIBUTING.md for future reference.
This was referenced Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: examples
Improvements or additions to examples
pkg: create-turbo
Issues related to npx create-turbo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The community has been contributing more and more examples as Turborepo usage has grown. This is so exciting for those of us on the core team, but we've had a hard time maintaining so many examples. It's a lot of work to keep up with the breadth of tools that work great with Turborepo, and the JavaScript ecosystem moves fast.
Because of this, we've come up with a strategy so that we can set expectations correctly with the community. We're picking out ~5 examples that we're committing to maintaining as shining representatives of JavaScript monorepo greatness, leaving the rest to be maintained by the community.
We will communicate this directly in
create-turbo
invocations, leaving a note for users when they pick out a community-supported example.Testing Instructions
Should not show a
Note
log:devcreateturbo --example https://github.com/vercel/turborepo/tree/shew-0f97e/examples/basic
Should show a
Note
log:devcreateturbo --example https://github.com/vercel/turborepo/tree/shew-0f97e/examples/with-docker