Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): mark core supported examples #9707

Merged
merged 7 commits into from
Jan 17, 2025
Merged

chore(examples): mark core supported examples #9707

merged 7 commits into from
Jan 17, 2025

Conversation

anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented Jan 15, 2025

Description

The community has been contributing more and more examples as Turborepo usage has grown. This is so exciting for those of us on the core team, but we've had a hard time maintaining so many examples. It's a lot of work to keep up with the breadth of tools that work great with Turborepo, and the JavaScript ecosystem moves fast.

Because of this, we've come up with a strategy so that we can set expectations correctly with the community. We're picking out ~5 examples that we're committing to maintaining as shining representatives of JavaScript monorepo greatness, leaving the rest to be maintained by the community.

We will communicate this directly in create-turbo invocations, leaving a note for users when they pick out a community-supported example.

Testing Instructions

Should not show a Note log: devcreateturbo --example https://github.com/vercel/turborepo/tree/shew-0f97e/examples/basic
Should show a Note log: devcreateturbo --example https://github.com/vercel/turborepo/tree/shew-0f97e/examples/with-docker

@anthonyshew anthonyshew requested a review from a team as a code owner January 15, 2025 16:52
@turbo-orchestrator turbo-orchestrator bot added the area: examples Improvements or additions to examples label Jan 15, 2025
Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 10:50pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 10:50pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 10:50pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 10:50pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 10:50pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 10:50pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 10:50pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 10:50pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 10:50pm

Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small follow up regarding create-turbo logging

packages/create-turbo/src/commands/create/index.ts Outdated Show resolved Hide resolved
@anthonyshew
Copy link
Contributor Author

@tknickman Thought it was going to bloat the PR for review, but I'm game! Done!

@anthonyshew anthonyshew requested a review from tknickman January 16, 2025 22:45
@anthonyshew anthonyshew enabled auto-merge (squash) January 16, 2025 22:45
examples/basic/README.md Outdated Show resolved Hide resolved
examples/basic/README.md Outdated Show resolved Hide resolved
@anthonyshew anthonyshew merged commit cbdeecd into main Jan 17, 2025
38 checks passed
@anthonyshew anthonyshew deleted the shew-0f97e branch January 17, 2025 18:07
anthonyshew added a commit that referenced this pull request Jan 18, 2025
### Description

Following up on #9707 with a note in CONTRIBUTING.md for future
reference.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples Improvements or additions to examples pkg: create-turbo Issues related to npx create-turbo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants