-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: split examples tests #9729
Merged
Merged
ci: split examples tests #9729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
turbo-orchestrator
bot
added
the
area: examples
Improvements or additions to examples
label
Jan 20, 2025
chris-olszewski
approved these changes
Jan 21, 2025
This was referenced Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, our examples testing loop is too slow. Changing just one of the examples causes all of them to miss cache.
This PR instead runs tests only for changed examples. This is going to end up being an even larger improvement given that I've additionally set up a test for each package manager for each core-maintained example, effectively tripling the amount of testing needed.
Notes
This probably isn't the most elegant way to write this - but it was the easiest to understand. GitHub Actions is just...really hard to work with and my patience has run out. Maybe I'll clean this up later, or maybe some kind soul will review me and give me a quick way to DRY it up.
.github/workflows
are all duplicates of each other, but one for each example.turborepo-tests/example-*
are creating tests for all of our supported package managers where we used to only test one package manager per example.Testing Instructions
CI