Write mode #69
+1,739
−1,052
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| const fs = require('fs') | ||
| const path = require('path') | ||
| const webpack = require('webpack') | ||
| const MemoryFS = require('memory-fs') | ||
|
|
||
| jest.setTimeout(20000) | ||
|
|
||
| it(`should generate correct output for relative to source path`, async () => { | ||
| const dir = `${__dirname}/relative-to-source` | ||
| const entry = `${dir}/input.js` | ||
| const expected = fs | ||
| .readFileSync(`${dir}/output.js`) | ||
| .toString() | ||
| .trim() | ||
| // Windows support | ||
| .replace(/\r/g, '') | ||
|
|
||
| const mfs = new MemoryFS() | ||
| const compiler = webpack({ | ||
| entry, | ||
| optimization: { nodeEnv: false, minimize: false }, | ||
| mode: 'production', | ||
| target: 'node', | ||
| output: { | ||
| path: '/', | ||
| filename: 'index.js', | ||
| libraryTarget: 'commonjs2', | ||
| }, | ||
| module: { | ||
| rules: [ | ||
| { | ||
| test: /\.(js|mjs|node)$/, | ||
| parser: { amd: false }, | ||
| use: [ | ||
| { | ||
| loader: | ||
| __dirname + '/../src/asset-relocator', | ||
| options: { | ||
| relativeToSource: true, | ||
| writeMode: true | ||
| } | ||
| }, | ||
| ], | ||
| }, | ||
| ], | ||
| }, | ||
| }) | ||
|
|
||
| compiler.outputFileSystem = mfs | ||
|
|
||
| try { | ||
| var stats = await new Promise((resolve, reject) => { | ||
| compiler.run((err, stats) => { | ||
| if (err) return reject(err) | ||
| resolve(stats) | ||
| }) | ||
| }) | ||
| } catch (err) { | ||
| if (shouldError) return | ||
| throw err | ||
| } | ||
|
|
||
| let code | ||
| try { | ||
| code = mfs.readFileSync('/index.js', 'utf8') | ||
| } catch (e) { | ||
| throw new Error(stats.toString()) | ||
| } | ||
|
|
||
| const actual = code | ||
| .trim() | ||
| // Windows support | ||
| .replace(/\r/g, '') | ||
|
|
||
| try { | ||
| expect(actual).toBe(expected) | ||
| } catch (e) { | ||
| // useful for updating fixtures | ||
| fs.writeFileSync(`${dir}/actual.js`, actual) | ||
| throw e | ||
| } | ||
| }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,125 @@ | ||
| module.exports = | ||
| /******/ (function(modules) { // webpackBootstrap | ||
| /******/ // The module cache | ||
| /******/ var installedModules = {}; | ||
| /******/ | ||
| /******/ // The require function | ||
| /******/ function __webpack_require__(moduleId) { | ||
| /******/ | ||
| /******/ // Check if module is in cache | ||
| /******/ if(installedModules[moduleId]) { | ||
| /******/ return installedModules[moduleId].exports; | ||
| /******/ } | ||
| /******/ // Create a new module (and put it into the cache) | ||
| /******/ var module = installedModules[moduleId] = { | ||
| /******/ i: moduleId, | ||
| /******/ l: false, | ||
| /******/ exports: {} | ||
| /******/ }; | ||
| /******/ | ||
| /******/ // Execute the module function | ||
| /******/ modules[moduleId].call(module.exports, module, module.exports, __webpack_require__); | ||
| /******/ | ||
| /******/ // Flag the module as loaded | ||
| /******/ module.l = true; | ||
| /******/ | ||
| /******/ // Return the exports of the module | ||
| /******/ return module.exports; | ||
| /******/ } | ||
| /******/ | ||
| /******/ | ||
| /******/ // expose the modules object (__webpack_modules__) | ||
| /******/ __webpack_require__.m = modules; | ||
| /******/ | ||
| /******/ // expose the module cache | ||
| /******/ __webpack_require__.c = installedModules; | ||
| /******/ | ||
| /******/ // define getter function for harmony exports | ||
| /******/ __webpack_require__.d = function(exports, name, getter) { | ||
| /******/ if(!__webpack_require__.o(exports, name)) { | ||
| /******/ Object.defineProperty(exports, name, { enumerable: true, get: getter }); | ||
| /******/ } | ||
| /******/ }; | ||
| /******/ | ||
| /******/ // define __esModule on exports | ||
| /******/ __webpack_require__.r = function(exports) { | ||
| /******/ if(typeof Symbol !== 'undefined' && Symbol.toStringTag) { | ||
| /******/ Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' }); | ||
| /******/ } | ||
| /******/ Object.defineProperty(exports, '__esModule', { value: true }); | ||
| /******/ }; | ||
| /******/ | ||
| /******/ // create a fake namespace object | ||
| /******/ // mode & 1: value is a module id, require it | ||
| /******/ // mode & 2: merge all properties of value into the ns | ||
| /******/ // mode & 4: return value when already ns object | ||
| /******/ // mode & 8|1: behave like require | ||
| /******/ __webpack_require__.t = function(value, mode) { | ||
| /******/ if(mode & 1) value = __webpack_require__(value); | ||
| /******/ if(mode & 8) return value; | ||
| /******/ if((mode & 4) && typeof value === 'object' && value && value.__esModule) return value; | ||
| /******/ var ns = Object.create(null); | ||
| /******/ __webpack_require__.r(ns); | ||
| /******/ Object.defineProperty(ns, 'default', { enumerable: true, value: value }); | ||
| /******/ if(mode & 2 && typeof value != 'string') for(var key in value) __webpack_require__.d(ns, key, function(key) { return value[key]; }.bind(null, key)); | ||
| /******/ return ns; | ||
| /******/ }; | ||
| /******/ | ||
| /******/ // getDefaultExport function for compatibility with non-harmony modules | ||
| /******/ __webpack_require__.n = function(module) { | ||
| /******/ var getter = module && module.__esModule ? | ||
| /******/ function getDefault() { return module['default']; } : | ||
| /******/ function getModuleExports() { return module; }; | ||
| /******/ __webpack_require__.d(getter, 'a', getter); | ||
| /******/ return getter; | ||
| /******/ }; | ||
| /******/ | ||
| /******/ // Object.prototype.hasOwnProperty.call | ||
| /******/ __webpack_require__.o = function(object, property) { return Object.prototype.hasOwnProperty.call(object, property); }; | ||
| /******/ | ||
| /******/ // __webpack_public_path__ | ||
| /******/ __webpack_require__.p = ""; | ||
| /******/ __webpack_require__.ab = __dirname + "/"; | ||
| /******/ __relativeToSource = __dirname; | ||
| /******/ | ||
| /******/ | ||
| /******/ // Load entry module and return exports | ||
| /******/ return __webpack_require__(__webpack_require__.s = 0); | ||
| /******/ }) | ||
| /************************************************************************/ | ||
| /******/ ([ | ||
| /* 0 */ | ||
| /***/ (function(module, exports, __webpack_require__) { | ||
|
|
||
| /* WEBPACK VAR INJECTION */(function(__dirname) {const fs = __webpack_require__(1) | ||
| const path = __webpack_require__(2) | ||
|
|
||
|
|
||
| fs.writeFileSync('./test.js', 'Test') | ||
|
|
||
| fs.writeFileSync('/tmp/test.js', 'Test') | ||
|
|
||
| fs.writeFileSync(__relativeToSource + 'test.js', 'Test') | ||
|
|
||
| fs.writeFileSync(path.resolve(__dirname, 'test.js'), 'Test') | ||
|
|
||
| const _basePath = __relativeToSource | ||
| const asset3 = 'asset3.txt'; | ||
|
|
||
| fs.writeFileSync(_basePath + '/' + asset3, 'Test'); | ||
| /* WEBPACK VAR INJECTION */}.call(this, "/")) | ||
|
|
||
| /***/ }), | ||
| /* 1 */ | ||
| /***/ (function(module, exports) { | ||
|
|
||
| module.exports = require("fs"); | ||
|
|
||
| /***/ }), | ||
| /* 2 */ | ||
| /***/ (function(module, exports) { | ||
|
|
||
| module.exports = require("path"); | ||
|
|
||
| /***/ }) | ||
| /******/ ]); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"
writeMode" makes the option sound like you're switching from "read mode" to "write mode".Let's rename this to be
writeSupportorrelocateWrites.