fix: adds error message for user registration

verdaccio · Sep 21, 2018 · 0bab945 · 0bab945
1 parent 345aef7
commit 0bab945
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/___tests___/utils.test.js b/src/___tests___/utils.test.js
@@ -156,9 +156,15 @@ describe('sanityCheck', () => {
     expect(input.message).toEqual('unauthorized access');
     expect(verifyFn).toHaveBeenCalled();
   });
-  it('should throw error max number of users', () => {
+  it('should throw error for registration disabled of users', () => {
     const verifyFn = () => {};
     const input = sanityCheck('username', users.test, verifyFn, users, -1);
+    expect(input.status).toEqual(409);
+    expect(input.message).toEqual('user registration disabled');
+  });
+  it('should throw error max number of users', () => {
+    const verifyFn = () => {};
+    const input = sanityCheck('username', users.test, verifyFn, users, 1);
     expect(input.status).toEqual(403);
     expect(input.message).toEqual('maximum amount of users reached');
   });

diff --git a/src/utils.js b/src/utils.js
@@ -127,6 +127,13 @@ export function sanityCheck(
 
   hash = users[user];
 
+  if (maxUsers < 0) {
+    err = Error('user registration disabled');
+    // $FlowFixMe
+    err.status = 409;
+    return err;
+  }
+
   if (hash) {
     const auth = verifyFn(password, users[user]);
     if (auth) {