https with .pfx file configuration is ignored

[yogevyuval]

#349 for some reason introduces a regression of a feature that seems to once work. https.pfx option is currently being ignored because of the following if statement:

if (!config.https || !config.https.key || !config.https.cert || !config.https.ca)

which was committed instead of the code that once worked:

if (!config.https || !((config.https.key && config.https.cert && config.https.ca) || config.https.pfx))

Currently we only check if there is key, cert and ca options and if not a warning is shown and the process exits.

To Reproduce
Steps to reproduce the behavior:

1. Create a PFX file and add it according to the documentation
2. Run verdaccio
3. An error is shown:

'You have enabled HTTPS and need to specify either ',
' "https.key", "https.cert" and "https.ca" or ',
' "https.pfx" and optionally "https.passphrase" ',
'to run https server'

Expected behavior
We should check if the configuration has a key, cert and ca OR a pfx file.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.