Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute purity of AstCMethodHard #4460

Merged

Conversation

RRozak
Copy link
Member

@RRozak RRozak commented Sep 7, 2023

It is a part extracted from #4437. It computes the purity of AstCMethodHard nodes.

src/V3AstNodeExpr.h Outdated Show resolved Hide resolved
src/V3AstNodes.cpp Outdated Show resolved Hide resolved
src/V3AstNodes.cpp Outdated Show resolved Hide resolved
@RRozak RRozak force-pushed the rrozak/compute-purity-AstCMethodhard branch from b820015 to 1ed5329 Compare September 8, 2023 13:37
@wsnyder
Copy link
Member

wsnyder commented Sep 8, 2023

Feel free to squash merge once tests pass.

Signed-off-by: Ryszard Rozak <[email protected]>
Signed-off-by: Ryszard Rozak <[email protected]>
@RRozak RRozak force-pushed the rrozak/compute-purity-AstCMethodhard branch from edec919 to 02fc0ba Compare September 11, 2023 08:46
@RRozak
Copy link
Member Author

RRozak commented Sep 11, 2023

The fails were because most of void methods weren't on the list. It passed at the beginning, because I called the setPurity() function only in one of constructors. I found that that constructor is unused. I think it's better to remove that constructor and I created a separate PR: #4473.

Signed-off-by: Ryszard Rozak <[email protected]>
@RRozak RRozak force-pushed the rrozak/compute-purity-AstCMethodhard branch from c0d2f4d to ea0da85 Compare September 11, 2023 10:04
@RRozak RRozak merged commit b66c415 into verilator:master Sep 11, 2023
@RRozak RRozak deleted the rrozak/compute-purity-AstCMethodhard branch September 11, 2023 11:06
kamilrakoczy pushed a commit to antmicro/verilator that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants