Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New UI features #7

Merged
merged 15 commits into from
Mar 12, 2024
Merged

New UI features #7

merged 15 commits into from
Mar 12, 2024

Conversation

eiksta
Copy link

@eiksta eiksta commented Mar 8, 2024

New UIFeature flags + tests for verji-develop

Merge branch 'develop' into New-UI-Features

# Conflicts:
	src/components/views/right_panel/UserInfo.tsx
	test/components/views/right_panel/UserInfo-test.tsx
@eiksta eiksta requested review from thoraj and JohnSimonsen March 8, 2024 13:05
@thoraj
Copy link

thoraj commented Mar 8, 2024

We aim to have a green board for the checks before we merge.
So:

  • Take care of adding an appropriate label to the PR
  • Fix failing test
  • Fix linting errors

@thoraj thoraj added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Mar 11, 2024
@eiksta eiksta merged commit bba2f5a into verji-develop Mar 12, 2024
15 checks passed
@eiksta
Copy link
Author

eiksta commented Mar 13, 2024

New UIFeature flags for CreateRoom, UserInfo, RoomList and Homepage

Create room
As we want our users to only create Private encrypted rooms, ve wish to have some of the options in create room encapsuled by UIFeatureflags. This way we can ensure that all rooms are private, encrypted and not public and knockable.
CreateRoomE2eeSection = "UIFeature.createRoomE2eeSection",
CreateRoomShowJoinRuleDropdown = "UIFeature.createRoomShowJoinRuleDropdown",
CreateRoomShowAdvancedSettings = "UIFeature.createRoomShowAdvancedSettings",

UserInfo
As our customers are using Element/Verji for business purposes, we want to restrict the users to delete (redact) messages, and to share the link to other users, to prevent unwanted/uninvited people into rooms.
UserInfoVerifyDevice = "UIFeature.userInfoVerifyDevice",
UserInfoShareLinkToUserButton = "UIFeature.userInfoShareLinkToUserButton",
UserInfoRedactButton = "UIFeature.userInfoRedactButton",

Homepage
We would like to hide the 3 buttons from the HomePage behind an UIFeature flag, to prevent our users to have multiple ways of doing things.
HomePageButtons = "UIFeature.homePageButtons",

RoomList
When creating a new room from the Roomlist, 2 choices appear, New Room and Explore public rooms. As we dont use public rooms, we would like to hide the option behind a feature flag.
RoomListExplorePublicRooms = "UIFeature.roomListExplorePublicRooms",

In this way we, and possible others, take benefit of not manually handle these changes inhouse on a later stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants