-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use shims instead of direct operations on PATH #256
Conversation
There's a problem on Windows, so change this to a draft. |
As I expected the directory to be the link instead of the executable file, many tools' executable programs will depend on the directory they are in. Just like https://github.com/Schniz/fnm |
Yes. It's not that big of a problem, we can just implement the program exactly as mentioned in #84. |
I like the soft link directory solution very much. I have used several version management tools using this method and it works well. I look forward to this implementation. |
fix #253
fix #84
fix #235
fix version-fox/vfox-golang#9
Instead of modifying the
PATH
directly, this change uses the fixed path$VFOX_HOME/shims
and$VFOX_SHELL_TMEP/shims
instead.Currently, the way to generate shim is very violent, later we need to ask plugins to tell
vfox
what bins need to be generated shim. see #191 (comment)