Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: errors caused by hyphen support after upgrading to v0.5.5 #360

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

leoliu0605
Copy link
Contributor

fix(sdk.go): refactor GetLocalSdkPackage to improve version handling and simplify directory processing logic

@leoliu0605 leoliu0605 changed the title Fix errors caused by hyphen support after upgrading to v0.5.5 fix: errors caused by hyphen support after upgrading to v0.5.5 Sep 27, 2024
@ciscoski
Copy link
Contributor

ciscoski commented Sep 27, 2024

Sorry about it, I was actually going to PR https://github.com/ciscoski/vfox/tree/fix/plugin-name .

@leoliu0605
Copy link
Contributor Author

Sorry about it, I was actually going to PR https://github.com/ciscoski/vfox/tree/fix/plugin-name .

Hi @ciscoski, I looked at your changes and still used '-' as the split character for name and version. However, this will cause errors if there is also a '-' in the version.

You can take a look at my changes; actually, the version is passed into this function right from the start, so we can directly use it to split out the name. This approach is more reasonable and won't encounter any character conflict issues again.

@ciscoski
Copy link
Contributor

indeed this is a better solution.

@bytemain bytemain merged commit c9d1e06 into version-fox:main Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants