Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Durable user notifications and begin Cell embedding formalism #2513

Merged
merged 20 commits into from
Jan 25, 2022

Conversation

invisig0th
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #2513 (e421b94) into master (5adb01d) will decrease coverage by 0.09%.
The diff coverage is 99.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2513      +/-   ##
==========================================
- Coverage   97.16%   97.06%   -0.10%     
==========================================
  Files         197      198       +1     
  Lines       37421    37567     +146     
==========================================
+ Hits        36359    36466     +107     
- Misses       1062     1101      +39     
Flag Coverage Δ
linux 97.06% <99.42%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/jsonstor.py 98.29% <98.52%> (+0.04%) ⬆️
synapse/cortex.py 96.37% <100.00%> (-0.47%) ⬇️
synapse/lib/cell.py 97.83% <100.00%> (+0.01%) ⬆️
synapse/lib/slabseqn.py 98.36% <100.00%> (+0.03%) ⬆️
synapse/lib/stormlib/notifications.py 100.00% <100.00%> (ø)
synapse/lib/stormtypes.py 98.64% <100.00%> (+<0.01%) ⬆️
synapse/tests/utils.py 94.05% <100.00%> (-2.00%) ⬇️
synapse/lib/hiveauth.py 96.28% <0.00%> (-0.71%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5adb01d...e421b94. Read the comment docs.

synapse/cortex.py Outdated Show resolved Hide resolved
@invisig0th invisig0th changed the title WIP: Durable user notifications Durable user notifications and begin Cell embedding formalism Jan 24, 2022
Copy link
Contributor

@vEpiphyte vEpiphyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need docs for stormtypes.py update

synapse/lib/stormtypes.py Show resolved Hide resolved
@invisig0th invisig0th merged commit 1b2d327 into master Jan 25, 2022
@invisig0th invisig0th deleted the visi-usernotif branch January 25, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants