Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit dbt default macros vs dbt-vertica macros #17

Closed
arosychuk opened this issue Mar 1, 2022 · 1 comment · Fixed by #18
Closed

Audit dbt default macros vs dbt-vertica macros #17

arosychuk opened this issue Mar 1, 2022 · 1 comment · Fixed by #18
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@arosychuk
Copy link
Contributor

There are a lot of macros that may or may not be supported by the dbt-vertica implementation.

Suggestion of doing a full audit, to see what is implemented, and what is not.

https://github.com/dbt-labs/dbt-core/tree/main/core/dbt/include/global_project/macros

@arosychuk arosychuk self-assigned this Mar 1, 2022
@arosychuk
Copy link
Contributor Author

I've started a full audit of this, and have refactored the current adapter.sql into the same format the dbt global_project/macros models the functions there. Hopefully this can help us stay on track of what changes are added per each release. I feel the adapter tests are okay, though I feel there are a lot of functions that are NOT being tested at the moment, that we should also include or evaluate.

@arosychuk arosychuk added the documentation Improvements or additions to documentation label Mar 2, 2022
@arosychuk arosychuk linked a pull request Mar 2, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant