Refactor of the Code Base #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyreagan
approved these changes
Mar 2, 2022
dbt/include/vertica/macros/README.md
Outdated
| @@ -0,0 +1,65 @@ | |||
| # dbt-vertica Macro Implementations | |||
|
|
|||
| Below is a table for what macros the current Vertica adapter supports for dbt. This is constantly improving and changing as both dbt adds new functionality, as well as the dbt-vertica driver improvies. This list is based upon dbt 1.0.3, with the list found under https://github.com/dbt-labs/dbt-core/tree/main/core/dbt/include/global_project/macros. | |||
There was a problem hiding this comment.
Thanks. Fixed the typo.
It definitely makes life easier for developers. I saw they were refactoring the whole testing suite, removing a lot of the "magic" from what's going on behind the scenes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A big refactor of the code base.
Modeled it off of how dbt structures their global_macros and also created a table to see what we support, and what we don't, and for what is NOT supported, throw an exception, and hope someone creates an Issue or Pull Request to implement it.
All tests still pass successfully. There was failures along the refactoring, which is a good sign the tests actually work, and I haven't broken anything that was being tested.