Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict use of anonymous identifier #1124

Merged

Conversation

taichi-ishitani
Copy link
Contributor

Currently, anonymous identifier (_) can be used at any location.
This is invalid situation and caseses #1122.

This PR is to add limitation to use of anonymous identifier to fix this situation.
Anonymous identifier can be used only for:

  • clock domain
  • unconnected output port

fix #1122

@taichi-ishitani taichi-ishitani force-pushed the check_anonymous_identifier branch 2 times, most recently from d587c14 to 5bed034 Compare December 5, 2024 05:26
@taichi-ishitani taichi-ishitani force-pushed the check_anonymous_identifier branch 5 times, most recently from 52fd486 to 5984489 Compare December 6, 2024 00:49
anonymous identifier can be used for
- clock domain
- unconnected output port

(refs: veryl-lang#1122)
@taichi-ishitani taichi-ishitani force-pushed the check_anonymous_identifier branch from 5984489 to c8f5938 Compare December 7, 2024 10:44
@dalance dalance merged commit a72bc2a into veryl-lang:master Dec 9, 2024
7 checks passed
@taichi-ishitani taichi-ishitani deleted the check_anonymous_identifier branch December 9, 2024 00:28
@dalance dalance added this to the v0.13.4 milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No error is reported for an anonymous identifier used as a factor
2 participants