Fix issue that unassign_variable error is reported many times unexpectedly
#1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taichi-ishitani
force-pushed
the
many_unassign_variable_errors
branch
from
6119f10 to
2a77682
Compare
taichi-ishitani
force-pushed
the
many_unassign_variable_errors
branch
from
2a77682 to
040a0b2
Compare
dalance
reviewed
Dec 19, 2024
crates/analyzer/src/analyzer.rs
Outdated
| &symbol.token.into(), | ||
| )); | ||
| } | ||
| for (_, list) in self.var_refs.iter().filter(|(key, _)| { |
There was a problem hiding this comment.
This for seems to be too long. How about using tempolary value like below?
let var_refs = self.var_refs.iter().filter(...);
for (_, list) in var_refs {
}
crates/analyzer/src/analyzer.rs
Outdated
| let assign_list: Vec<_> = list.iter().filter(|(_i, x)| x.is_assign()).collect(); | ||
| for (i, var_ref) in &list { | ||
| if let VarRefType::ExpressionTarget { r#type } = var_ref.r#type { | ||
| if matches!( |
There was a problem hiding this comment.
Could you give an appropriate name to the if condition?
taichi-ishitani
force-pushed
the
many_unassign_variable_errors
branch
from
040a0b2 to
eaa0c13
Compare
|
I fixed them. |
taichi-ishitani
force-pushed
the
many_unassign_variable_errors
branch
from
eaa0c13 to
c1cefce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1126