Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

Enhance path build expression #306

Merged
merged 7 commits into from
Nov 23, 2020
Merged

Enhance path build expression #306

merged 7 commits into from
Nov 23, 2020

Conversation

yixinglu
Copy link
Contributor

Now we can use path builder expression to build the path for following cases:

  1. V
  2. V, E
  3. V, Path
  4. Path, V, E
  5. Path, Path
  6. Path, V, Path

@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label Nov 16, 2020
nevermore3
nevermore3 previously approved these changes Nov 18, 2020
View reviewed changes
@yixinglu yixinglu force-pushed the enhance-path-build-expr branch from bbe39d0 to 011931f Compare November 18, 2020 14:56
@yixinglu yixinglu mentioned this pull request Nov 19, 2020
Merged
CPWstatic
CPWstatic reviewed Nov 22, 2020
View reviewed changes
Copy link
Contributor

@CPWstatic CPWstatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

src/common/expression/test/ExpressionTest.cpp Show resolved Hide resolved
src/common/function/FunctionManager.cpp Outdated Show resolved Hide resolved
@yixinglu yixinglu force-pushed the enhance-path-build-expr branch from 0dc6bd1 to f2d5b35 Compare November 23, 2020 02:07
@yixinglu yixinglu merged commit 06f8fab into vesoft-inc:master Nov 23, 2020
@yixinglu yixinglu deleted the enhance-path-build-expr branch November 23, 2020 08:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CPWstatic CPWstatic CPWstatic approved these changes

@nevermore3 nevermore3 nevermore3 approved these changes

@dutor dutor Awaiting requested review from dutor

@laura-ding laura-ding Awaiting requested review from laura-ding

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yixinglu @nevermore3 @CPWstatic