Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick #436: support domain name #438

Merged
merged 1 commit into from
Feb 10, 2022
Merged

cherry-pick #436: support domain name #438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions client/src/main/java/com/vesoft/nebula/client/meta/AbstractMetaClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import com.facebook.thrift.transport.TTransport;
import com.google.common.base.Preconditions;
import com.google.common.net.InetAddresses;
import com.google.common.net.InternetDomainName;
import com.vesoft.nebula.client.graph.data.HostAddress;
import java.util.List;

Expand All @@ -29,9 +30,11 @@ public AbstractMetaClient(List<HostAddress> addresses, int timeout,
for (HostAddress address : addresses) {
String host = address.getHost();
int port = address.getPort();
// check if the address is a valid ip address or uri address and port is valid
if ((!InetAddresses.isInetAddress(host) || !InetAddresses.isUriInetAddress(host))
|| (port <= 0 || port >= 65535)) {
// check if the address is a valid ip, uri address or domain name and port is valid
if (!(InetAddresses.isInetAddress(host)
|| InetAddresses.isUriInetAddress(host)
|| InternetDomainName.isValid(host))
|| (port <= 0 || port >= 65535)) {
throw new IllegalArgumentException(String.format("%s:%d is not a valid address",
host, port));
}
Expand Down