This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
Replace injector with gmock, support clean invalid balance plan #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
critical27
commented
Dec 8, 2020
•
critical27
commented
- Replace all injector in ut with gmock
- Support clean invalid balance plan, rely on support balance data reset plan nebula-common#342, https://github.com/vesoft-inc/nebula-graph/pull/463/files
critical27
requested review from
darionyaphet,
liuyu85cn,
panda-sheep,
bright-starry-sky and
dangleptr
dutor
previously approved these changes
Dec 23, 2020
support balance data reset plan only clean last failed plan add count * test rebased
liuyu85cn
approved these changes
Dec 24, 2020
panda-sheep
approved these changes
Dec 24, 2020
critical27
added a commit
to critical27/nebula-storage
that referenced
this pull request
Dec 31, 2020
critical27
added a commit
that referenced
this pull request
Jan 7, 2021
* balance plan store in desc order * fix task could not be executed if the part has been removed from source * revert some code in #232 * fix ut Co-authored-by: yaphet <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.