feat: add file config in db #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veezhang
reviewed
Jan 31, 2023
| for _, name := range request.Names { | ||
| target := filepath.Join(dir, name) | ||
| if _, err := os.Stat(target); err != nil { | ||
| logx.Infof("del file error %v", err) |
| target := filepath.Join(dir, name) | ||
| if _, err := os.Stat(target); err != nil { | ||
| logx.Infof("del file error %v", err) | ||
| return ecode.WithInternalServer(err) |
Comment on lines
+119
to
+123
| if result.Error != nil { | ||
| logx.Errorf("get file config record in db error %v", result.Error) | ||
| fileConfig.Delimiter = "," | ||
| fileConfig.WithHeader = false | ||
| } |
There was a problem hiding this comment.
Why init with ",", false?
There was a problem hiding this comment.
Considering that the user can directly upload the file to the corresponding directory of the server, the configuration record of the file may not exist in the database, so the default value is set and returned to the front end.
| line, err := reader.Read() | ||
| sample := "" | ||
| for count < 5 { | ||
| line, _, err := reader.ReadLine() |
There was a problem hiding this comment.
for count:=0; count<5; count++ ?
| } | ||
| file.Close() |
| func (f *fileService) FileUpload() error { | ||
| dir := f.svcCtx.Config.File.UploadDir | ||
| auth := f.ctx.Value(auth.CtxKeyUserInfo{}).(*auth.AuthData) | ||
| host := auth.Address + ":" + strconv.Itoa(auth.Port) |
huaxiabuluo
reviewed
Feb 2, 2023
| uploadList: StudioFile[]; | ||
| } | ||
|
|
||
| const DelimiterConfigModal = (props: { onConfirm: (string) => void }) => { |
There was a problem hiding this comment.
missing type, check all code in this commit
Comment on lines
100
to
109
| const newData = [...data]; | ||
| newData.splice(index, 1); | ||
| const checkedList = newData.filter((file) => file.withHeader); | ||
| setState({ | ||
| checkAll: checkedList.length === newData.length, | ||
| indeterminate: !!checkedList.length && checkedList.length < newData.length, | ||
| data: newData, | ||
| activeItem: isActive ? null : activeItem, | ||
| previewContent: isActive ? [] : previewContent, | ||
| }); |
There was a problem hiding this comment.
const newData = data.filter((_, i) => i !== index);
const checkedNum = newData.reduce((n, file) => n + (file.withHeader & 1), 0);
setState({
checkAll: checkedNum === newData.length,
indeterminate: !!checkedNum && checkedNum < newData.length,
data: newData,
activeItem: isActive ? null : activeItem,
previewContent: isActive ? [] : previewContent,
});
huaxiabuluo
reviewed
Feb 8, 2023
| @@ -1,13 +1,15 @@ | |||
| import { Button, Popover, Table } from 'antd'; | |||
| import { } from 'antd/lib/button'; | |||
| import styles from './index.module.less'; | ||
| interface IProps { | ||
| file: StudioFile; | ||
| children: any; |
There was a problem hiding this comment.
type IProps = PropsWithChildren<{ file: StudioFile; }>
interface IProps {
file: StudioFile;
children: ReactNode;
}
Comment on lines
+79
to
+84
| fileList.forEach(file => { | ||
| file.path = `${file.name}`; | ||
| file.withHeader = false; | ||
| file.delimiter = ','; | ||
| }); | ||
| setPreviewList(fileList); |
There was a problem hiding this comment.
setPreviewList(fileList.map(file => ({
...file,
path: `${file.name}`,
withHeader: false,
delimiter: ',',
));
hetao92
added a commit
that referenced
this pull request
Feb 9, 2023
* feat: add upload logic * feat: add file config in db * mod: update api * feat: support update file config * feat: support cluster import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: