Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide hash function for the go/python/java/c++ client #1281

Closed
whitewum opened this issue Nov 17, 2019 · 5 comments
Closed

provide hash function for the go/python/java/c++ client #1281

whitewum opened this issue Nov 17, 2019 · 5 comments
Assignees
Labels
good first issue Community: perfect as the first pull request

Comments

@whitewum
Copy link
Contributor

whitewum commented Nov 17, 2019

Is your feature request related to a problem? Please describe.

Ther is no explanation about which hash function used in console. I've to look up the Nebula C++ code, and guess for my language.

> yield hash("mike")

So when I use golang client to insert vertex id(vid), I don't know which hash function to use (I think in golang, it is murmurhash2A)

Describe the solution you'd like

I hope Nebula can provide a nebula::util::hash

Describe alternatives you've considered

You can tell user the hash function (murmurhash, m, r, seed... ), and let user search for their own language packages. But that's a really really bad idea. It takes me half hour to check my golang hash is consistent with nebula hash ( I don't think anyone else wants to do this search).

Additional context

Add any other context or screenshots about the feature request here.

@whitewum
Copy link
Contributor Author

I hope you can provide it in the next release. It's simple and useful.

@jude-zhu jude-zhu added the good first issue Community: perfect as the first pull request label Dec 11, 2019
@jude-zhu jude-zhu added this to the R201910_RC3 milestone Dec 11, 2019
@jude-zhu jude-zhu removed this from the R201910_RC3 milestone Mar 20, 2020
@rexdouglass
Copy link

rexdouglass commented Nov 17, 2020

I second this. I'm currently just looking for documentation on which hash algorithm Nebula uses for IDs.

I'm doing my data prep in spark which now has the 64-bit xxhash function. I was thinking I could keep everything in sync if I generated IDs in spark, imported them through the Nebula spark importer, and then later refered to them as plain text on the fly as hash('original plain text name')

So for example, I'm working with RDF data, I want to create a vertex for each URI, and I want the option of easily refering to them as either their 64 bit int or original plain text names.

@wey-gu
Copy link
Contributor

wey-gu commented May 18, 2021

This issue/feature request is valid and should be created in the corresponding repos. :) @jamieliu1023

@CPWstatic
Copy link
Contributor

We had discussed this early this year, we would not support this feature.

yixinglu pushed a commit to yixinglu/nebula that referenced this issue Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Community: perfect as the first pull request
Projects
None yet
Development

No branches or pull requests

8 participants