Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hot Fix] fix invalid usage of rocksdb iterator #1663

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

critical27
Copy link
Contributor

@critical27 critical27 commented Jan 17, 2020

This is the last place we pass range parameter by value.

close #1659, close #1660.

Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

@monadbobo monadbobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dutor dutor merged commit 653a19d into vesoft-inc:master Jan 17, 2020
@critical27 critical27 deleted the fix branch January 17, 2020 14:19
jude-zhu pushed a commit to jude-zhu/nebula that referenced this pull request Jan 19, 2020
dutor added a commit that referenced this pull request Jan 19, 2020
* fix prefix released before rocksdb iterator (#1663)

* Add version info to action job and build docker images for release branches (#1654)

* Add compiler version for job name

* Run docker and package workflow for release branchs

* Build release type for PR workflow

Co-authored-by: dutor <[email protected]>

Co-authored-by: Doodle <[email protected]>
Co-authored-by: Xinglu Yee <[email protected]>
Co-authored-by: dutor <[email protected]>
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
* correct covarage

* resolve conflicts

Co-authored-by: hs.zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UT] Failure in delete_edges_test [UT] Failure in scan_vertex_test
3 participants