Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use range in delete edges #2404

Merged
merged 2 commits into from
Dec 2, 2020
Merged

use range in delete edges #2404

merged 2 commits into from
Dec 2, 2020

Conversation

critical27
Copy link
Contributor

Use delete range in delete edges, there are some encode problem that we can not use it in delete vertices, contact me if interested.

Other changes:

  1. lower flush log level in EventListener
  2. fix leader not returned in scan

@codecov-io
Copy link

Codecov Report

Merging #2404 (697df7f) into master (2249c03) will decrease coverage by 0.30%.
The diff coverage is 80.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2404      +/-   ##
==========================================
- Coverage   86.46%   86.16%   -0.31%     
==========================================
  Files         649      648       -1     
  Lines       64374    66027    +1653     
==========================================
+ Hits        55662    56891    +1229     
- Misses       8712     9136     +424     
Impacted Files Coverage Δ
src/common/filter/geo/GeoParams.h 100.00% <ø> (ø)
src/common/hdfs/HdfsCommandHelper.cpp 0.00% <0.00%> (-75.00%) ⬇️
src/common/stats/StatsManager.h 100.00% <ø> (ø)
src/graph/DownloadExecutor.cpp 0.00% <0.00%> (ø)
src/graph/DropSpaceExecutor.h 0.00% <ø> (ø)
src/graph/FetchEdgesExecutor.cpp 79.32% <0.00%> (-0.27%) ⬇️
src/graph/FindPathExecutor.h 50.00% <ø> (ø)
src/graph/IngestExecutor.cpp 0.00% <0.00%> (ø)
src/graph/LookupExecutor.h 0.00% <ø> (ø)
src/graph/test/GroupByLimitTest.cpp 90.54% <ø> (ø)
... and 129 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daab888...697df7f. Read the comment docs.

Copy link
Contributor

@bright-starry-sky bright-starry-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@liuyu85cn liuyu85cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yixinglu yixinglu merged commit f163ebc into vesoft-inc:master Dec 2, 2020
@amber-moe amber-moe added doc affected PR: improvements or additions to documentation and removed doc affected PR: improvements or additions to documentation labels Dec 2, 2020
@critical27 critical27 deleted the delete branch January 8, 2021 03:34
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants