Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the rfcs to folder from issues. #2490

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Move the rfcs to folder from issues. #2490

merged 2 commits into from
Aug 12, 2021

Conversation

Shylock-Hg
Copy link
Contributor

Pull request a rfc is better than issue to review and record.

@Shylock-Hg Shylock-Hg added the ready-for-testing PR: ready for the CI test label Aug 11, 2021
@Shylock-Hg Shylock-Hg requested review from a team August 11, 2021 03:40
@Shylock-Hg Shylock-Hg changed the title Move the rfcs to folder fro issues. Move the rfcs to folder from issues. Aug 11, 2021
izhuxiaoqing
izhuxiaoqing previously approved these changes Aug 11, 2021
View reviewed changes
@Shylock-Hg Shylock-Hg requested a review from a team August 11, 2021 03:44
yixinglu
yixinglu reviewed Aug 11, 2021
View reviewed changes
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer to put it in the docs/rfcs directory

@Shylock-Hg
Copy link
Contributor Author

prefer to put it in the docs/rfcs directory

Done.

@Shylock-Hg Shylock-Hg requested review from yixinglu, izhuxiaoqing and a team August 11, 2021 06:10
@wey-gu
Copy link
Contributor

wey-gu commented Aug 11, 2021 •
edited
Loading

This change brought better community transparency and will be much more accessible and trackable for new comers 👍🏻.

@Shylock-Hg
Copy link
Contributor Author

Shylock-Hg commented Aug 11, 2021 •
edited by wey-gu
Loading

This change brought better community transparency and will be much more accessible and trackable for new comers 👍🏻.

I think so.

@Shylock-Hg Shylock-Hg requested review from a team August 11, 2021 07:18
@yixinglu yixinglu merged commit 6c3a33b into vesoft-inc:master Aug 12, 2021
@jamieliu1023 jamieliu1023 mentioned this pull request Aug 14, 2021
Closed
@Shylock-Hg Shylock-Hg deleted the feature/rfc-docs branch February 9, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jievince jievince jievince approved these changes

@yixinglu yixinglu yixinglu approved these changes

@izhuxiaoqing izhuxiaoqing Awaiting requested review from izhuxiaoqing

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Shylock-Hg @wey-gu @yixinglu @jievince @izhuxiaoqing