Enable prefix bloom filter by default #2860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
requested review from
darionyaphet,
cangfengzhs,
liwenhui-soul,
liuyu85cn,
bright-starry-sky,
panda-sheep and
pengweisong
Comment on lines
+1186
to
+1187
| auto eng = folly::stringPrintf("Engine %zu", i); | ||
| obj[eng] = std::move(value(val)); |
|
only display on HTTP interface ? |
Yeah, rocksdb stats also provide in http only |
bright-starry-sky
previously approved these changes
Sep 23, 2021
Yeah, I have tested before. The compatibility need to check carefully later. |
panda-sheep
reviewed
Sep 24, 2021
| } | ||
| bbtOpts.whole_key_filtering = FLAGS_enable_rocksdb_whole_key_filtering; |
There was a problem hiding this comment.
Have a question:
When enable_rocksdb_prefix_filtering and enable_rocksdb_whole_key_filterin are both true,
which one is used?
There was a problem hiding this comment.
Both of them could used at the same time.
panda-sheep
approved these changes
Sep 24, 2021
| rocksdb::ReadOptions options; | ||
| // prefix_same_as_start is false by default | ||
| options.total_order_seek = FLAGS_enable_rocksdb_prefix_filtering; |
This was referenced Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable_rocksdb_statisticsto true). For example:Close #2601
@randomJoe211, please check if we need to add a doc about the http interfaces.
@HarrisChu, I have check the compatibility during test, everything works fine. Please pay attention to compatible test later. (write new data to old storage, check data)