Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta upgrader v3 #3540

Merged
merged 6 commits into from
Jan 5, 2022
Merged

Meta upgrader v3 #3540

merged 6 commits into from
Jan 5, 2022

Conversation

darionyaphet
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Which issue(s)/PR(s) this PR relates to?

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context/ Design document:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the corresponding label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

                                                            `

@darionyaphet darionyaphet changed the title Meta up v3 Meta upgrader v3 Dec 23, 2021
src/meta/MetaVersionMan.cpp Show resolved Hide resolved
src/daemons/MetaDaemon.cpp Outdated Show resolved Hide resolved
src/meta/MetaVersionMan.cpp Outdated Show resolved Hide resolved
src/meta/MetaVersionMan.cpp Show resolved Hide resolved
src/meta/upgrade/MetaDataUpgrade.cpp Show resolved Hide resolved
src/meta/upgrade/MetaDataUpgrade.cpp Outdated Show resolved Hide resolved
src/meta/upgrade/MetaDataUpgrade.cpp Show resolved Hide resolved
src/meta/upgrade/MetaDataUpgrade.cpp Show resolved Hide resolved
@darionyaphet darionyaphet added the wip Solution: work in progress label Dec 29, 2021
@darionyaphet darionyaphet force-pushed the meta-up-v3 branch 9 times, most recently from 320330c to c321abc Compare December 30, 2021 13:36
@Sophie-Xie Sophie-Xie added the cherry-pick-v3.0 PR: need cherry-pick to this version label Jan 4, 2022
@darionyaphet darionyaphet added ready-for-testing PR: ready for the CI test and removed wip Solution: work in progress labels Jan 4, 2022
critical27
critical27 previously approved these changes Jan 4, 2022
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, please do some test to make sure the cluster can be upgraded successfully.

src/meta/upgrade/MetaDataUpgrade.cpp Show resolved Hide resolved
@darionyaphet
Copy link
Contributor Author

darionyaphet commented Jan 4, 2022

Generally LGTM, please do some test to make sure the cluster can be upgraded successfully.

I have tested the nebula v 2.6.1 upgrade to v 3 both space with group and space without group.

Of course , I will support more test later

@darionyaphet
Copy link
Contributor Author

I have tested the space with group and without group

(root@nebula) [(none)]> add zone z_0 "192.168.8.215":55540
Execution succeeded (time spent 3518/3966 us)

Wed, 05 Jan 2022 23:41:31 CST

(root@nebula) [(none)]> add zone z_1 "192.168.8.215":55550
Execution succeeded (time spent 2661/3065 us)

Wed, 05 Jan 2022 23:41:35 CST

(root@nebula) [(none)]> add zone z_2 "192.168.8.215":55570
Execution succeeded (time spent 2608/3070 us)

Wed, 05 Jan 2022 23:41:40 CST

(root@nebula) [(none)]> add group g z_0,z_1,z_2
Execution succeeded (time spent 2942/3418 us)

Wed, 05 Jan 2022 23:41:44 CST

(root@nebula) [(none)]> create SPACE test1(vid_type=FIXED_STRING(32)) on g
Execution succeeded (time spent 5045/5565 us)

Wed, 05 Jan 2022 23:41:48 CST

(root@nebula) [(none)]> create SPACE test2(vid_type=FIXED_STRING(32))
Execution succeeded (time spent 3349/3775 us)

After upgrade to V3:

(root@nebula) [(none)]> show zones
+-------+-----------------+-------+
| Name  | Host            | Port  |
+-------+-----------------+-------+
| "z_0" | "192.168.8.215" | 55540 |
| "z_1" | "192.168.8.215" | 55550 |
| "z_2" | "192.168.8.215" | 55570 |
+-------+-----------------+-------+
Got 3 rows (time spent 2974/3863 us)

Wed, 05 Jan 2022 23:51:30 CST

(root@nebula) [(none)]> show create space test_0
[ERROR (-1005)]: Space not existed!

Wed, 05 Jan 2022 23:51:34 CST

(root@nebula) [(none)]> show create space test1
+---------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Space   | Create Space                                                                                                                                                          |
+---------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| "test1" | "CREATE SPACE `test1` (partition_num = 100, replica_factor = 1, charset = utf8, collate = utf8_bin, vid_type = FIXED_STRING(32), atomic_edge = false) ON z_0,z_1,z_2" |
+---------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------+
Got 1 rows (time spent 2609/3417 us)

Wed, 05 Jan 2022 23:51:35 CST

(root@nebula) [(none)]> show create space test2
+---------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Space   | Create Space                                                                                                                                                          |
+---------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| "test2" | "CREATE SPACE `test2` (partition_num = 100, replica_factor = 1, charset = utf8, collate = utf8_bin, vid_type = FIXED_STRING(32), atomic_edge = false) ON z_0,z_1,z_2" |
+---------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------+
Got 1 rows (time spent 2681/3474 us)

Wed, 05 Jan 2022 23:51:39 CST

Copy link
Contributor

@liuyu85cn liuyu85cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@critical27 critical27 merged commit 1147e89 into vesoft-inc:master Jan 5, 2022
@Sophie-Xie Sophie-Xie added the doc affected PR: improvements or additions to documentation label Jan 5, 2022
Sophie-Xie pushed a commit that referenced this pull request Jan 10, 2022
* Replace group when create space

* Support white list

* fix test case

* support zone operations

* fix

* Support meta upgrade v3
critical27 added a commit that referenced this pull request Jan 10, 2022
* Fix typos (#3615)

Co-authored-by: kyle.cao <[email protected]>

* fix fetch edges tostring (#3613)

Co-authored-by: Sophie <[email protected]>
Co-authored-by: Yichen Wang <[email protected]>

* fix create space assign offline host (#3583)

* fix create space

* fix test case

Co-authored-by: Harris.Chu <[email protected]>

* Disable ARM version docker image since related third party not ready (#3618)

* Unify raft error code (#3620)

* Meta upgrader v3 (#3540)

* Replace group when create space

* Support white list

* fix test case

* support zone operations

* fix

* Support meta upgrade v3

* add more check about parse host result (#3628)

* Ut fix (#3611)

* Enable ut and fix chaindelete

* Add mock server default worker

* fix service crash (#3616)

* Cleanup branch param in package script (#3622)

* fix crash when the expression exceed the depth (#3606)

* Enhance login password check (#3629)

* fix_batch_insert_problem (#3627)

* filter data before batch insert

* add test cases

* add more testcase

* add notifyStop() for metaClient (#3621)

* add notifyStop() for metaClient

* do clean

* Fix removeSession() (#3651)

Co-authored-by: Yee <[email protected]>

* Issue3373 storage exit crash (#3553)

* use rcu replace thread local

fix storage exit crash

format

address some comment

* fix bug

* fix bug

* Fix coalesce bug (#3653)

* fix coalesce

* fix test

* add test

* add tck

* fix

* fix

* fix

* delete double check agg in where clause (#3647)

Co-authored-by: Yee <[email protected]>
Co-authored-by: cpw <[email protected]>

* fix meta crash after create space (#3660)

Co-authored-by: Yichen Wang <[email protected]>

Co-authored-by: Yichen Wang <[email protected]>
Co-authored-by: kyle.cao <[email protected]>
Co-authored-by: jimingquan <[email protected]>
Co-authored-by: yaphet <[email protected]>
Co-authored-by: Harris.Chu <[email protected]>
Co-authored-by: Yee <[email protected]>
Co-authored-by: Doodle <[email protected]>
Co-authored-by: Alex Xing <[email protected]>
Co-authored-by: endy.li <[email protected]>
Co-authored-by: [email protected] <[email protected]>
Co-authored-by: hs.zhang <[email protected]>
Co-authored-by: jakevin <[email protected]>
Co-authored-by: cpw <[email protected]>
@darionyaphet darionyaphet deleted the meta-up-v3 branch January 17, 2022 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.0 PR: need cherry-pick to this version doc affected PR: improvements or additions to documentation ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants