Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mold linker #5331

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Support mold linker #5331

merged 2 commits into from
Feb 10, 2023

Conversation

yixinglu
Copy link
Contributor

@yixinglu yixinglu commented Feb 10, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

use the mold linker to speed up nebula compilation:

  1. download the mold linker from the release page and decompress the tar to your $PATH directory, such as $HOME/.local by
    tar zxf mold-1.10.1-x86_64-linux.tar.gz --strip-components=1 -C $HOME/.local/
  2. enter the nebula repo build directory
  3. specify the NEBULA_USE_LINKER variable when you configure the cmake:
    cmake -DNEBULA_USE_LINKER=mold ..
    
  4. happy to build nebula now

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@yixinglu yixinglu requested a review from a team as a code owner February 10, 2023 03:08
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bravo.

@yixinglu yixinglu merged commit d0b1464 into vesoft-inc:master Feb 10, 2023
@yixinglu yixinglu deleted the mold-linker branch February 10, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants