compatible swarm-client is automatically downloaded form jenkins #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vad1mo
commented
Mar 7, 2018
Vad1mo
commented
- Download latest swarm client from current jenkins on start. see Add ability to download the client directory from the plugin installed in Jenkins jenkinsci/swarm-plugin#62
- Support Env vars and secret files
- Document Variables
- Sensible Defaults for variables
- Support Env vars and secret files - Document Variables - Sensible Defaults for variables
|
I did change a few of the variables not sure if that will break some of the others setups. |
vfarcic
reviewed
Mar 7, 2018
| # exec su jenkins -c "exec java -jar /home/jenkins/swarm-client.jar ${COMMAND_OPTIONS}" | ||
| java -jar /swarm-client.jar -master ${JENKINS_URL:="http://jenkins:8080"} -username ${USR:="jenkins-swarm-agent"} ${PASWD_OPT} ${SWARM_CLIENT_OPTS} |
There was a problem hiding this comment.
Maybe we should add an if statement so that COMMAND_OPTIONS is used if it has a value, otherwise, the new command? That way we'd maintain backward compatibility. What do you think?
There was a problem hiding this comment.
Do you mean something like this:
if env.${COMMAND_OPTIONS}.isNotEmpty() then
java -jar /swarm-client.jar ${COMMAND_OPTIONS}
else
java -jar /swarm-client.jar -master ${JENKINS_URL:="http://jenkins:8080"} -username ${USR:="jenkins-swarm-agent"} ${PASWD_OPT} ${SWARM_CLIENT_OPTS}There was a problem hiding this comment.
Something like that should do. Bear in mind that PASWD_OPT needs to be added to both cases.
|
I just realized that I wrote a review a while ago but forgot to submit it :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.