Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Site Finds Pt. 2 #1939

Merged
merged 6 commits into from
Feb 6, 2025
Merged

Video Site Finds Pt. 2 #1939

merged 6 commits into from
Feb 6, 2025

Conversation

kjbranch
Copy link
Contributor

@kjbranch kjbranch commented Feb 4, 2025

Here are some more of the easier fixes that were found when going through the logic videos

@@ -543,7 +543,7 @@
{
"id": 18,
"link": [1, 4],
"name": "Suitless Water Shinecharge, Diagonal Shinespark to the Top",
"name": "Suitless Stutter Water Shinecharge, Diagonal Shinespark to the Top",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would we think about replacing "Suitless Stutter Water Shinecharge" with simply "Stutter Water Shinecharge", to simplify strat names like this? Looks like currently we're not consistent across rooms, though "Suitless Stutter Water Shinecharge" is used more often.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a good call. Doing this as a separate commit.

@@ -1223,6 +1223,31 @@
"It helps to face right before Shinesparking."
]
},
{
"link": [3, 4],
"name": "Come in Shinecharging, Shinespark",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A 3->5 "Come in Shinecharging, Shinespark" strat is also possible:
https://videos.maprando.com/video/4506

Doesn't have to be added in this PR, but it would be canShinechargeMovementTricky. For the mid-air spark variant, you pretty much want to get the tricky dash jump (like in the video), otherwise it's hard to avoid hitting the bottom Choot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was only working on the easy that had "FIXME" in the notes for this PR. I'll probably go through incompletes after v117.

"SpaceJump",
"canLongIBJ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to keep an IBJ option, keeping in mind that when we get to blue suit logic without Speedbooster, pausing (hence Gravity jump) may not always be an option.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nevermind, IBJ is still covered by the 1->4 strat.

@@ -841,6 +841,7 @@
"name": "Artificial Morph Remotely Collect the Item",
"requires": [
"canEnterGMode",
{"itemNotCollectedAtNode": 4},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[6, 4] collects the item, so this wouldn't work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting the collectsItem where GMode ends is better, but remote collections have been written where you pick up the item and then leave to end gmode in the following strat.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to go through all of the remote acquire again soonish, and use collectsItem. I bet there are some strats where it's expected to use the item obtained during the remote acquire, even though the item isn't usable yet. (Map Rando won't have this problem, but it still feels like an important fix I want to prioritize)

"canGravityJump",
{"or": [
"HiJump",
"canCarefulJump"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might not be obviously possible in medium? I don't know what the reaction is to a decentish looking gravity jump that doesn't reach the door.
I wouldn't move its placement or make a notable. So that must mean I'd leave it like this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There arent many that require this big of a jump, those that are more than it I think require a canTrickyJump. The window didn't feel too tight compared to other canCarefulJump strats and you can retry it.

"link": [2, 2],
"name": "G-Mode Setup - Get Hit By Beetom",
"name": "G-Mode Setup - Get Hit By Beetom (Speedless Speedway)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GMode setup with speed is just gone then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, very confused. I'll fix it

@osse101 osse101 merged commit 039ef6b into vg-json-data:master Feb 6, 2025
1 check passed
@kjbranch kjbranch deleted the sam-videos-2 branch February 10, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants