-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SMASHED and SLAMMED Upgrade for the Summon Pitbulls spell. #36792
Conversation
|
||
var/list/pitbulls_exclude_kinlist = list() //all pitbulls go in here so pitbulls won't attack other pitbulls when feeling treacherous (and instead attack the wizard) | ||
|
||
/spell/aoe_turf/conjure/pitbull/perform(mob/user = usr, skipcharge = 0, list/target_override, var/ignore_timeless = FALSE, var/ignore_path = null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if this specific change will break stuff cause it didn't cause any issues as a plain perform() call on local, but it failed the linter check here without all that stuff in the (), but I can't test that today
>1 more brute damage on average |
it's a very small increase, but it stacks when you have more than 1 pitbull biting you simultaneously. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10/10 PR just remove the redundant code
/mob/living/simple_animal/hostile/pitbull/smashednslammed/summoned_pitbull/death(var/gibbed = FALSE) | ||
..() | ||
if(!gibbed) | ||
if(prob(90)) | ||
animate(src, alpha = 0, time = 4 SECONDS) | ||
spawn(4 SECONDS) | ||
qdel(src) | ||
else | ||
gib() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unnecessary as this behavior is already inherited from the parent proc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smashed and slammed is not a child of the summoned pitbulls (which would make that code redundant), it's a child of regular pitbulls, meaning the summoned one is a child of the toadline pitbulls (which in turn is a child of regular pitbulls), it's not redundant code.
As for why have regular non summonable smashed pitbulls, there are some non wizard sources, like the syndie pokeballs or the goldcore reactions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Christ, that's a mess. I won't force you to, but cleaning up code here for consistency would be nice.
/mob/living/simple_animal/hostile/pitbull/smashednslammed/summoned_pitbull | ||
faction = "wizard" // so they get along with other wizard mobs | ||
meat_type = /obj/item/weapon/ectoplasm //a magical dog | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary as this is already inherited from the parent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
upboated just for that derek bum image alone |
3x Pimpy |
remind me to add wizard lab robes at some point also i see TG items in the OP image so you're getting a 👎 |
Have you ever thought.. Hmm, those pitbulls I summon sure could be more smashed and slammed...
Hi, I'm Arch-Wizard Derekus Baumicus, The Allmaker, and I'm declaring WAR on NT stations and non-wizards with the new SMASHED and SLAMMED Upgrade!
BANG BANG BANG! And 3 Toadline Pitbulls are summonned! Just make sure to UPGRADE the spell before using it.
AND YES! THIS IS EXACTLY HOW THEY LOOK!
What do they do? Why should I upgrade?
Excellent question! A toadline pitbull is so SMASHED and SLAMMED that they can pass through AIRLOCKS!
With some effort, it's NOT INSTANTANEOUS, but they sure can crawl through! They're so SMASHED that they can even walk through each other!
The boys at the wizard towerstation even managed to make them bite ever so slightly harder! They do move a bit slower though, what with their stumpy legs.
But Derekus, surely those spells are exorbitantly expensive, have you seen the prices of high quality arcana lately???
FEAR NOT MY FLEDGLING STUDENT OF THE ARTS! For you can access this upgrade for just a measly 20 spell points!
But why?
It allows You, yes YOU!, to focus harder on the pitbulls! It does mean you have to spend more points on them meaning you have less for emergency escape spells, but we both know you were not planning on that when you bought the Toadlines!
Assuming you get both speed upgrades AND the pitbull upgrade, you'll be using a full 80 of your starting 100 points.
Are you SURE these spells work fine, sir? Last time we tried one of these we almost summoned Nar's-
FRET NOT! These spells were tested with High intensity sieges against NanoTrasen stations! Our boys in the lab robes even made sure that you do NOT summon the traditional pitbull when casting, and that upgrading works as intended!
🆑