fix: bitcoin lib final fixes #14

steph-rs · 2024-08-19T16:21:22Z

What ❔

Why ❔

Checklist

PR title corresponds to the body of PR (we generate changelog entries from PRs).
Tests for the changes have been added / updated.
Documentation comments have been added / updated.
Code has been formatted via zk fmt and zk lint.

core/lib/via_btc_client/src/client/rpc_client.rs

core/lib/via_btc_client/src/client/mod.rs

core/lib/via_btc_client/src/client/rpc_client.rs

core/lib/via_btc_client/src/indexer/mod.rs

core/lib/via_btc_client/src/inscriber/mod.rs

mpavlovic-txfusion

Marked few things to improve.

steph-rs · 2024-08-21T12:03:43Z

In the next commits I will resolve conflicts with base branch and fix the regtest module, including feature

…ation' into bitcoin-lib-fixes # Conflicts: # core/lib/via_btc_client/src/client/mod.rs # core/lib/via_btc_client/src/regtest.rs

mpavlovic-txfusion

Looks great!

core/lib/via_btc_client/src/inscriber/mod.rs

irnb · 2024-08-22T11:54:26Z

I'm gonna have some conflict with this branch and also it's miss of new change on bitcoin client
but let's merge it and i'll rebase my branch with this branch and those new changes

LGTM

Steph Sinyakov and others added 4 commits August 19, 2024 14:55

fix: re-exports [ci skip]

3ee0477

chore: \zk fmt\ [ci skip]

c1af2e7

fix: update tests [ci skip]

25aeb2a

chore: a few more fixes [ci skip]

7165b33

github-actions bot added the external-contribution label Aug 19, 2024

steph-rs added 5 commits August 19, 2024 19:04

fix: signer module [ci skip]

8879001

fix: add logs, retries to rpc_client

8372a39

fix: add logs, a few logic fixes for BtcClient [ci skip]

e420047

fix: add logs, tests for indexer` [ci skip]

8dac0f4

fix: add logs, script_builder refactoring for inscriber` [ci skip]

d0afa03

steph-rs marked this pull request as ready for review August 20, 2024 17:28