Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace travis-ci with Github Actions #2500

Merged
merged 2 commits into from
Nov 25, 2020
Merged

Replace travis-ci with Github Actions #2500

merged 2 commits into from
Nov 25, 2020

Conversation

Geod24
Copy link
Contributor

@Geod24 Geod24 commented Nov 25, 2020

This will be a bit problematic for Buildkite.

@s-ludwig : See https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing and the result: https://www.jeffgeerling.com/blog/2020/travis-cis-new-pricing-plan-threw-wrench-my-open-source-works

This only does Ubuntu, as currently we can't merge any PR because a "Required" check (Travis) is not working anymore.
In the future I will try to add Mac.

Travis CI is severely limiting their open-source plan,
essentially making it unusable for Vibe.d.
@Geod24 Geod24 requested review from s-ludwig and wilzbach November 25, 2020 04:07
@s-ludwig
Copy link
Member

Probably makes sense to also add Windows (as for vibe-core) at some point. Seems like the workflow hasn't generated any jobs, though.

@Geod24
Copy link
Contributor Author

Geod24 commented Nov 25, 2020

Yeah, I wanted to add macOS / Windows, but since all PRs are being blocked from being merged, I figured I'd start slow :)
You don't see the checks in this PR because it wasn't merged. However, you can see the run in my fork: https://github.com/Geod24/vibe.d/actions/runs/382413068

There's still the question of the failing test. For some reason, the TLS client tunnel succeeds when a failure is expected. I assume that's because of configuration difference between the new mongodb/redis and the old one (e.g. the old one didn't support TLS?). It would be great if you could take a look.

@s-ludwig
Copy link
Member

Okay, I'll merge like this and then take a look at the test, so that I can actually see the failure.

@s-ludwig s-ludwig merged commit 657356c into vibe-d:master Nov 25, 2020
@Geod24 Geod24 deleted the new-ci branch November 25, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants